-
Notifications
You must be signed in to change notification settings - Fork 817
Update/connection banner multisite url redirection #43594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Definitely not familiar with the codebase, but I think this started being an issue with #39865, which didn't consider multisites when replacing only I opted for a regex in the same ConnectBanner to avoid other issues, but another option would be to be more defensive down the road here and check for multisites and replace the site_url. I think it's not the best option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!
This works well, thank you.
Fixes VULCAN-101
Proposed changes:
ConnectBanner
The replace code was introduced in Add/skip pricing page when connecting from editor blocks #39865 but didn't consider multisites.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Same as #39865
And also #43340