Update/connection banner multisite url redirection

[darssen]

Fixes VULCAN-101

Proposed changes:

• Replace not only wp-admin but all before the first occurrence when getting the redirect_uri in the ConnectBanner
  The replace code was introduced in Add/skip pricing page when connecting from editor blocks #39865 but didn't consider multisites.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Same as #39865
And also #43340

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/connection-banner-multisite-url-redirection branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/connection-banner-multisite-url-redirection

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[jp-launch-control]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

[darssen]

Definitely not familiar with the codebase, but I think this started being an issue with #39865, which didn't consider multisites when replacing only wp-admin/ I'm not 100% sure if that would be an issue for other places where the component is used although I doubt it.

I opted for a regex in the same ConnectBanner to avoid other issues, but another option would be to be more defensive down the road here and check for multisites and replace the site_url. I think it's not the best option.

[coder-karen]

Nice!!
This works well, thank you.

[chrisbliss18]

I wondered how the logic change would affect non-multisite sites using WordPress in its own directory. I tested using both methods listed on that page. I didn't run into any complications with method 1 (without URL change). However, I ran into something odd when testing with method 2 (with URL change).

When testing without WordPress in its own directory and when using method 1, I got the following prompt when following the "Connect Jetpack" button on the Blogroll block as the non-connected user:

However, when testing with WordPress in its own directory using method 2, I got something different:

Notice that "Connected as" changes to "Connecting as" and "Return to your site" changes to "Approve". I tested this repeatedly, sometimes creating new connections before starting the tests and sometimes reusing the existing connection. I always got this result despite getting to the prompt using a different user as per the instructions.

This means that I can't actually test this fix properly for such sites as somehow the connection flow is not properly identifying that the requesting user is different than the user logged in to wp.com.

Given this complication, I can't properly give a review to this PR.

[darssen]

Thanks for reviewing @chrisbliss18

Notice that "Connected as" changes to "Connecting as" and "Return to your site" changes to "Approve". I tested this repeatedly, sometimes creating new connections before starting the tests and sometimes reusing the existing connection. I always got this result despite getting to the prompt using a different user as per the instructions.

This means that I can't actually test this fix properly for such sites as somehow the connection flow is not properly identifying that the requesting user is different than the user logged in to wp.com.

Given this complication, I can't properly give a review to this PR.

Is this different from what happens in trunk? What happens when you Approve in the 2nd scenario, does it take you back to the post before, or it takes you to a wrong URL?

[chrisbliss18]

@darssen The same thing happens in both this branch and in trunk. Sorry for not clarifying before. So, this is a preexisting issue.

That being the case, I don't want to hold up this fix, but I do want to make sure that we 1) create a new issue for the problem that I found, and 2) ensure that we retest for this issue once we fix the issue that I identified.

[darssen]

@darssen The same thing happens in both this branch and in trunk. Sorry for not clarifying before. So, this is a preexisting issue.

That being the case, I don't want to hold up this fix, but I do want to make sure that we 1) create a new issue for the problem that I found, and 2) ensure that we retest for this issue once we fix the issue that I identified.

Since it is a separate issue, I went ahead and merged this one.

@chrisbliss18 Would it be possible for you to create the issue with the steps to test on non-multisite sites using WordPress in its own directory for method 2?