-
Notifications
You must be signed in to change notification settings - Fork 817
CRM: Remove Bootstrap dependency #43584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 In testing, with the PR applied on a Jurassic Ninja site, I can't spot the 'Finish and Go to your CRM' button when finishing the wizard. There is a successful Ajax request on the final step leading to this 'Finish' step of the wizard though, but the button styling isn't being applied properly (I don't see the styles for btn-success
being applied for example). The button is there though, the text is visible when hovering over it.
I re-tested on new JN sites without the branch and the button appears fine, and on another JN site spun up from the PR again the button is missing, even if caches are cleared.
Good catch! 😬 Fixed: a637025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the monorepo perspective. I'll leave functionality review to @coder-karen and @mikestottuk 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Button looks good now, all looks good from a testing perspective 👍
When reviewing I did see a good chunk of classnames in single quotes instead of double quotes (from existing but linted code), but too many to make some quick commit suggestions - opted to leave them since it isn't a blocker at all.
@anomiex This had some dependency hiccups that needed merge from trunk; can you give a quick review from that angle? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The end result in https://github.com/Automattic/jetpack/pull/43584/files/a637025ac3b7a84eed11def166d8f23116e15c32..310f465a949877c643eeecb64ee9cdbd155cc295 looks good to me.
This PR removes the Bootstrap dependency from CRM; technically v3 has a vulnerability (https://nvd.nist.gov/vuln/detail/CVE-2024-6484) but despite enqueuing the JS, it's not actually used. It also used some CSS, which I copied and distilled to about 100 lines (this could be reduced further, but honestly the entire page needs a rewrite and this is good enough until then).
Note to the reviewer: I'd recommend reviewing changes up to (and not including) 814cf34, then 814cf34 (if desired, with whitespace changes hidden), and finally the commits after 814cf34.
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
/wp-admin/admin.php?page=zerobscrm-dash&jpcrm_force_wizard=1
Things should look and function nearly identical between
trunk
and this branch. The only thing I noticed was the placeholder font color being darker on this branch, but again, we're going for similar, as it never was perfect.