Skip to content

CRM: Remove Bootstrap dependency #43584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 26, 2025
Merged

CRM: Remove Bootstrap dependency #43584

merged 15 commits into from
May 26, 2025

Conversation

tbradsha
Copy link
Contributor

@tbradsha tbradsha commented May 22, 2025

This PR removes the Bootstrap dependency from CRM; technically v3 has a vulnerability (https://nvd.nist.gov/vuln/detail/CVE-2024-6484) but despite enqueuing the JS, it's not actually used. It also used some CSS, which I copied and distilled to about 100 lines (this could be reduced further, but honestly the entire page needs a rewrite and this is good enough until then).

Note to the reviewer: I'd recommend reviewing changes up to (and not including) 814cf34, then 814cf34 (if desired, with whitespace changes hidden), and finally the commits after 814cf34.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Go to /wp-admin/admin.php?page=zerobscrm-dash&jpcrm_force_wizard=1
  2. Go through the wizard.
  3. Ensure the final step submits (an AJAX request with a 200 response).

Things should look and function nearly identical between trunk and this branch. The only thing I noticed was the placeholder font color being darker on this branch, but again, we're going for similar, as it never was perfect.

@tbradsha tbradsha requested review from mikestottuk, coder-karen and a team May 22, 2025 22:39
@tbradsha tbradsha self-assigned this May 22, 2025
@tbradsha tbradsha added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels May 22, 2025
Copy link
Contributor

github-actions bot commented May 22, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the fix/crm/bootstrap_dependency branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/crm/bootstrap_dependency
bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/crm/bootstrap_dependency

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Plugin] CRM Issues about the Jetpack CRM plugin Admin Page React-powered dashboard under the Jetpack menu labels May 22, 2025
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link

jp-launch-control bot commented May 22, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/crm/admin/activation/welcome-to-jpcrm.php 0/157 (0.00%) 0.00% -1 💚

Full summary · PHP report · JS report

Copy link
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 In testing, with the PR applied on a Jurassic Ninja site, I can't spot the 'Finish and Go to your CRM' button when finishing the wizard. There is a successful Ajax request on the final step leading to this 'Finish' step of the wizard though, but the button styling isn't being applied properly (I don't see the styles for btn-success being applied for example). The button is there though, the text is visible when hovering over it.

I re-tested on new JN sites without the branch and the button appears fine, and on another JN site spun up from the PR again the button is missing, even if caches are cleared.

@tbradsha
Copy link
Contributor Author

the button styling isn't being applied properly

Good catch! 😬 Fixed: a637025

@tbradsha tbradsha requested a review from coder-karen May 23, 2025 13:27
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the monorepo perspective. I'll leave functionality review to @coder-karen and @mikestottuk 🙂

coder-karen
coder-karen previously approved these changes May 23, 2025
Copy link
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Button looks good now, all looks good from a testing perspective 👍

When reviewing I did see a good chunk of classnames in single quotes instead of double quotes (from existing but linted code), but too many to make some quick commit suggestions - opted to leave them since it isn't a blocker at all.

@tbradsha
Copy link
Contributor Author

@anomiex This had some dependency hiccups that needed merge from trunk; can you give a quick review from that angle?

Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbradsha tbradsha merged commit a7cf066 into trunk May 26, 2025
84 checks passed
@tbradsha tbradsha deleted the fix/crm/bootstrap_dependency branch May 26, 2025 15:43
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Plugin] CRM Issues about the Jetpack CRM plugin [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants