-
Notifications
You must be signed in to change notification settings - Fork 817
Enforce comment blocks allowlist on inner blocks #43573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Enforce comment blocks allowlist on inner blocks #43573
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
* @param array $blocks Array of blocks to filter. | ||
* @return array Filtered blocks. | ||
*/ | ||
private static function filter_blocks_recursive( $blocks ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like this shouldn't be so complicated, am I missing a convenience function or a better way of doing things?
Hmm the static analysis is failing because:
But the PHPCS says .......yup, using a null coalesce fails pre-commit checks
|
Fixes https://linear.app/a8c/issue/DOTCOM-13240/
Proposed changes:
Fixes an issue where disallowed blocks could be added as inner blocks
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: