Skip to content

Site: Add hosting_features to the WPCOM_JSON_API_GET_Site_Endpoint endpoint #43565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Site: Add hosting_features to the WPCOM_JSON_API_GET_Site_Endpoint endpoint #43565

wants to merge 2 commits into from

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented May 22, 2025 •
edited
Loading

Part of DOTCOM-13234, 183534-ghe-Automattic/wpcom

Proposed changes:

  • Add hosting_features to the WPCOM_JSON_API_GET_Site_Endpoint endpoint. We'll continue to implement the details on wpcom. With this change, we can reduce duplication and improve maintainability on Calypso

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply changes to your site
  • Call /sites/:site endpoint
  • Ensure you can see the hosting_features on the response

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 22, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the feat/add-wpcom-features-to-site-endpoint branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack feat/add-wpcom-features-to-site-endpoint

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] WPCOM API [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels May 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 22, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: June 3, 2025
    • Code freeze: June 2, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 22, 2025
@arthur791004 arthur791004 added the [Type] Feature Development of a new feature label May 22, 2025
@jp-launch-control JP Launch Control
Copy link

jp-launch-control bot commented May 22, 2025 •
edited
Loading

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/json-endpoints/class.wpcom-json-api-get-site-endpoint.php 468/620 (75.48%) -0.00% 1 ❤️‍🩹
projects/plugins/jetpack/sal/class.json-api-site-jetpack.php 2/95 (2.11%) -0.02% 1 ❤️‍🩹

Full summary · PHP report · JS report

@arthur791004 arthur791004 requested a review from a team May 22, 2025 09:40
@arthur791004 arthur791004 self-assigned this May 22, 2025
fushar
fushar reviewed May 22, 2025
View reviewed changes
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to come up with actual wpcom PR to verify that the combination is working.

projects/plugins/jetpack/sal/class.json-api-site-jetpack.php
* @return bool
*/
public function get_hosting_features() {
return false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this return null / empty array instead? The type is array.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the returned value of the get_plan function.

fushar
fushar reviewed May 22, 2025
View reviewed changes
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced to do this right now (also see: p1747900761252039/1747818829.817529-slack-C08JZTRS6NA).

At the very least, I think we need to come up with the actual list of features, the shape of the response, how it will be consumed... etc before actually implementing it

@arthur791004 arthur791004 force-pushed the feat/add-wpcom-features-to-site-endpoint branch from 0a05869 to ee97813 Compare May 23, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fushar fushar fushar left review comments

Assignees

@arthur791004 arthur791004

Labels
[Feature] WPCOM API [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Type] Feature Development of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthur791004 @fushar