Skip to content

Forms: Add multi step forms #43214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 119 commits into
base: trunk
Choose a base branch
from
Open

Forms: Add multi step forms #43214

wants to merge 119 commits into from

Conversation

lezama
Copy link
Contributor

@lezama lezama commented Apr 23, 2025

This pull request introduces multistep capabilities to the Jetpack forms package, allowing users to divide forms into multiple steps. This feature enhances the user experience for complex forms by breaking them into manageable chunks.

See: #41080

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

Copy link
Contributor

github-actions bot commented Apr 23, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/forms-multistep branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/forms-multistep

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Apr 23, 2025
Copy link
Contributor

github-actions bot commented Apr 23, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

jp-launch-control bot commented Apr 23, 2025

Code Coverage Summary

Coverage changed in 10 files. Only the first 5 are listed here.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/blocks/contact-form/edit.js 0/138 (0.00%) 0.00% 99 💔
projects/packages/forms/src/contact-form/class-contact-form-plugin.php 294/953 (30.85%) -2.18% 71 💔
projects/packages/forms/src/contact-form/js/validate-helper.js 16/54 (29.63%) -70.37% 38 💔
projects/packages/forms/src/contact-form/class-contact-form.php 558/885 (63.05%) -2.10% 29 💔
projects/packages/forms/src/blocks/contact-form/child-blocks.js 0/97 (0.00%) 0.00% 26 💔

24 files are newly checked for coverage. Only the first 5 are listed here.

File Coverage
projects/packages/forms/src/blocks/contact-form/components/add-step-controls/index.js 0/26 (0.00%) 💔
projects/packages/forms/src/blocks/contact-form/components/icons/StepContainerIcon.js 0/1 (0.00%) 💔
projects/packages/forms/src/blocks/contact-form/components/icons/StepIcon.js 0/1 (0.00%) 💔
projects/packages/forms/src/blocks/contact-form/components/step-controls/index.js 0/23 (0.00%) 💔
projects/packages/forms/src/blocks/form-progress-indicator/edit.js 0/14 (0.00%) 💔

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

@lezama lezama changed the title WIP: Forms: Multistep capabilities – spike! WIP: Forms: Multisteps capabilities [Spike!] Apr 24, 2025
@enejb enejb force-pushed the add/forms-multistep branch from 18af263 to 4b37516 Compare April 29, 2025 17:34
@lezama lezama force-pushed the add/forms-multistep branch from 595a222 to fdd3cb5 Compare May 7, 2025 20:50
@lezama lezama changed the title WIP: Forms: Multisteps capabilities [Spike!] Forms: Multistep [Spike!] May 7, 2025
@enejb enejb changed the title Forms: Multi step forms Forms: Add multi step forms May 22, 2025
@lezama lezama mentioned this pull request May 27, 2025
3 tasks
.wp-block-jetpack-form-step {
border: 1px solid #ddd;
padding: 20px;
border-radius: 4px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces instead of tabs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Button [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants