Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandon google-fonts-provider package #38063

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jun 26, 2024

Proposed changes:

The google-fonts-provider package made use of APIs that were provided by the Gutenberg plugin versions v12.8.0 to v16.3.0 and never made it into WordPress Core.

Meanwhile, the google-fonts module in the Jetpack plugin has been updated to use an API that was included in WordPress Core 6.4, which is the minimum version we support.

So let's abandon the package, and remove the back-compat code in the Jetpack plugin that used it.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1719259393606879-slack-CBG1CP4EN

Does this pull request change what data or activity we track or use?

No

Testing instructions:

The google-fonts-provider package made use of APIs that were provided by
the Gutenberg plugin versions v12.8.0 to v16.3.0 and never made it into
WordPress Core.

Meanwhile, the google-fonts module in the Jetpack plugin has been
updated to use an API that was included in WordPress Core 6.4, which is
the minimum version we support.

So let's abandon the package, and remove the back-compat code in the
Jetpack plugin that used it.
@anomiex anomiex added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Jun 26, 2024
@anomiex anomiex requested review from arthur791004 and a team June 26, 2024 14:56
@anomiex anomiex self-assigned this Jun 26, 2024
@anomiex anomiex enabled auto-merge (squash) June 26, 2024 14:56
Copy link
Contributor

github-actions bot commented Jun 26, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the remove/abandon-google-fonts-provider-package branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack remove/abandon-google-fonts-provider-package
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Google Fonts [Package] Google Fonts Provider [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Docs labels Jun 26, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for July 2, 2024 (scheduled code freeze on July 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No errors after downgrading to WP 6.4 and enabling the module.

@anomiex anomiex merged commit 3bc148f into trunk Jul 1, 2024
58 checks passed
@anomiex anomiex deleted the remove/abandon-google-fonts-provider-package branch July 1, 2024 15:16
@github-actions github-actions bot added this to the jetpack/13.5.1 milestone Jul 1, 2024
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants