Fix/form block submit button styles when errors #40762

ntsekouras · 2024-12-30T07:56:25Z

Proposed changes:

After this GB change button block styles were affected to stretch properly in flex containers. This resulted in the linked issue, where when we have required fields in a form and submit the form with expecting errors, the submit button has 'broken' styles.

A css solution could also be explored here, but I thought it makes more sense semantically to append the errors element outside the wp-block-jetpack-button wp-block-button container.

I'm new to Jetpack codebase so I might be missing context for the original decision to add the errors inside that container, but I'm not sure if it affects other things. I think not though by my testing, as if I understand correctly we always have wp-block-jetpack-button wp-block-button container, if we have a submit button. I'd love some testing/input from experienced Jetpack contributors.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Testing instructions:

In order to see the 'broken' styles you need to have Gutenberg activated.

Insert a Form block with required fields and a submit button. The contact form should be enough.
In front-end submit the form with errors - for example empty
Observe that the styles are not broken
Test the same without Gutenberg activated and you should see no visual changes or errors. It's just that errors are rendered in a different position.

Before	After

github-actions · 2024-12-30T07:57:10Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/form-block-submit-button-styles-when-errors branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/form-block-submit-button-styles-when-errors

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

ntsekouras · 2024-12-30T07:57:14Z

projects/packages/forms/src/contact-form/css/grunion.css

@@ -714,7 +714,6 @@ on production builds, the attributes are being reordered, causing side-effects
 }

 .contact-form__error {
-	margin-bottom: var(--wp--style--block-gap, 1.5rem);


This is the main css change. The others were from css formatter.

github-actions · 2024-12-30T07:57:20Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
🔴 Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:

## Does this pull request change what data or activity we track or use?

My PR adds *x* and *y*.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

bizanimesh

Thanks @ntsekouras - I tested the fix/form-block-submit-button-styles-when-errors branch - It looks like the issue has been fixed with this branch.

manzoorwanijk

This looks good.

ntsekouras added 2 commits December 30, 2024 09:32

Form block: Fix submit button styles when there are errors

be9d10d

add changelog entry

efcc928

ntsekouras added [Type] Bug When a feature is broken and / or not performing as intended [Block] Contact Form Form block (also see Contact Form label) [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. labels Dec 30, 2024

ntsekouras requested review from jp-imagines and bizanimesh December 30, 2024 07:56

ntsekouras self-assigned this Dec 30, 2024

ntsekouras commented Dec 30, 2024

View reviewed changes

github-actions bot added [Feature] Contact Form [Package] Forms [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Dec 30, 2024

ntsekouras added the [Status] Needs Team Review label Dec 30, 2024

bizanimesh mentioned this pull request Dec 31, 2024

Form block: Prevent submit button from getting larger when an error appears #40753

Closed

bizanimesh approved these changes Dec 31, 2024

View reviewed changes

ntsekouras requested review from jeherve and anomiex January 2, 2025 07:05

manzoorwanijk approved these changes Jan 2, 2025

View reviewed changes

ntsekouras merged commit 9f11871 into trunk Jan 2, 2025
64 checks passed

ntsekouras deleted the fix/form-block-submit-button-styles-when-errors branch January 2, 2025 07:21

github-actions bot removed [Status] Needs Team Review [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/form block submit button styles when errors #40762

Fix/form block submit button styles when errors #40762

ntsekouras commented Dec 30, 2024 •

edited

Loading

github-actions bot commented Dec 30, 2024 •

edited

Loading

ntsekouras Dec 30, 2024

github-actions bot commented Dec 30, 2024 •

edited

Loading

bizanimesh left a comment

manzoorwanijk left a comment

Fix/form block submit button styles when errors #40762

Fix/form block submit button styles when errors #40762

Conversation

ntsekouras commented Dec 30, 2024 • edited Loading

Proposed changes:

Other information:

Testing instructions:

github-actions bot commented Dec 30, 2024 • edited Loading

ntsekouras Dec 30, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 30, 2024 • edited Loading

bizanimesh left a comment

Choose a reason for hiding this comment

manzoorwanijk left a comment

Choose a reason for hiding this comment

ntsekouras commented Dec 30, 2024 •

edited

Loading

github-actions bot commented Dec 30, 2024 •

edited

Loading

github-actions bot commented Dec 30, 2024 •

edited

Loading