Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form block: Prevent submit button from getting larger when an error appears #40753

Closed
jp-imagines opened this issue Dec 27, 2024 · 4 comments · Fixed by #40762
Closed

Form block: Prevent submit button from getting larger when an error appears #40753

jp-imagines opened this issue Dec 27, 2024 · 4 comments · Fixed by #40762
Assignees
Labels
[Block] Contact Form Form block (also see Contact Form label) Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Contact Form [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. [Platform] Atomic [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Status] Escalated to Product Ambassadors [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jp-imagines
Copy link

Impacted plugin

Jetpack

Quick summary

If you submit a form without filling out all of the required fields, an error appears. At the same time, the submit button (a sibling element of the error) grows in size.

Steps to reproduce

  1. Add a Form block to a page.
  2. Ensure at least one field is set as "required."
  3. View the live page.
  4. Without filling out the required field, submit the form.

A clear and concise description of what you expected to happen.

The error should appear and the submit button should not change in size.

What actually happened

The submit button has a 100% height value, which causes it to become significantly larger when the error appears:

Screen.Capture.on.2024-12-27.at.14-26-08.mp4

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

Atomic

Logs or notes

Only tested/replicated on Atomic so far. Replicated on several themes, including a classic theme (Twenty Twenty) and block themes. Initial customer report in 9216021-zd-a8c.

@jp-imagines jp-imagines added [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Dec 27, 2024
@matticbot matticbot added the [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack label Dec 27, 2024
Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 9216021-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Dec 27, 2024
@bizanimesh
Copy link

👋 Hey @jp-imagines - I tried reproducing the issue on a desktop device, but it's working fine there. Then, I tried to reproduce the issue on a mobile device, but there also I don't see the issue.

I tried with Blank Canvas and Twenty Twenty-One themes. It might be possible the issue is linked to the theme. May we know which theme you are using?

QW1.mp4

@bizanimesh bizanimesh added Triaged [Pri] Normal and removed Needs triage Ticket needs to be triaged [Pri] High labels Dec 27, 2024
@matticbot matticbot moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Dec 27, 2024
@jp-imagines
Copy link
Author

@bizanimesh Thanks for testing this! I had initially replicated this on Twenty Twenty as well as Alonso and Creatio 2 (both Dotcom themes). I can replicate on Twenty Twenty-One as well, but deactivating Gutenberg fixes the issue on all themes.

I'm not sure if this would technically be a bug with Gutenberg, or a conflict between Gutenberg and Jetpack's Form block that needs resolving here. 🤔

@bizanimesh
Copy link

bizanimesh commented Dec 31, 2024

Thanks @jp-imagines - yes, I can now reproduce the issue after activating the Gutenberg plugin. Also, we have a fix here for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Contact Form Form block (also see Contact Form label) Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Contact Form [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. [Platform] Atomic [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Status] Escalated to Product Ambassadors [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Development

Successfully merging a pull request may close this issue.

4 participants