feat: Add support for vim script #354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-potter
requested changes
Jan 3, 2025
| @@ -27,6 +27,7 @@ tree-sitter-lua = "0.0.19" | |||
| tree-sitter-bash = "0.20.0" | |||
| tree-sitter-java = "0.20.0" | |||
| tree-sitter-nix = "0.0.1" | |||
| tree-sitter-vim = { git = "https://github.com/tree-sitter-grammars/tree-sitter-vim.git", tag = "v0.3.0" } | |||
There was a problem hiding this comment.
We can't depend on git repositories. They are unfortunately not allowed by crates.io.
There was a problem hiding this comment.
That's a shame.
Please check my comment in the PR description. None of the published crates are currently buildable with tree-sitter 0.20, which is the current requirement for harper.
Unless there is some other way, I guess this PR can be closed, and re-opened whenever the tree-sitter version is bumped.
|
Looks pretty straightforward. Same stuff as #353 applies here. |
|
I'll close the PR for now, because i'm not sure how to get rid of the git dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for vim script files.
It's using the 0.3.0 git tag instead of 0.5.4, because the latter depends on tree-sitter 0.21, which is not compatible with the 0.20 that is currently used.
Unfortunately, It's using the github url, instead of the published crate, because the 0.3.0 tag was never released on crates.io :(
This causes slightly long cloning times during the build.
I'm not sure what's the best way to go forward here, unless the tree-sitter version is bumped to one that is compatible with tree-sitter-vim 0.4.0, which is published on crates.io.