feat(harper-ls): remove deleted file/s diagnostics #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-potter
requested changes
Dec 5, 2024
| @@ -407,6 +435,34 @@ impl LanguageServer for Backend { | |||
|
|
|||
| async fn did_close(&self, _params: DidCloseTextDocumentParams) {} | |||
|
|
|||
| async fn did_delete_files(&self, params: DeleteFilesParams) { | |||
There was a problem hiding this comment.
It looks like you're just listening for files that have been deleted by the editor. If a file is deleted separately (i.e. via File Explorer or bash), this won't pick it up.
Would you mind adding listeners to watch for other kinds of deletions? I'd be happy to make it happen, just won't be able to for a bit.
There was a problem hiding this comment.
Yeah, this only works if a file is deleted within the editor. I'll look for a way so it'd also pick up deletions that happen outside of the editor. I'll turn this PR into a draft until it's ready.
| @@ -61,4 +61,23 @@ describe('Integration >', () => { | |||
| // Set config back to default value | |||
| await config.update('repeated_words', true, ConfigurationTarget.Workspace); | |||
| }); | |||
|
|
|||
| it('updates diagnostics when files are deleted', async () => { | |||
There was a problem hiding this comment.
Love the extensive test coverage you've been building out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that even after files are deleted, their diagnostics stay. This fixes that.