2075 -- Harper Auto-submits Reddit Comments #2079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe that problem was fixed in #2068. It just hasn't been released yet. |
elijah-potter
approved these changes
Oct 14, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Oct 17, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.67.0` -> `v0.68.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v0.68.0`](https://github.com/Automattic/harper/releases/tag/v0.68.0) [Compare Source](Automattic/harper@v0.67.0...v0.68.0) #### What's Changed - feat(core): rule to condense `miss spell` and friends by [@​elijah-potter](https://github.com/elijah-potter) in [#​2066](Automattic/harper#2066) - feat(chrome-ext): enable by default on WordPress pages by [@​elijah-potter](https://github.com/elijah-potter) in [#​2065](Automattic/harper#2065) - fix(chrome-ext): duplication test on Reddit by [@​elijah-potter](https://github.com/elijah-potter) in [#​2068](Automattic/harper#2068) - build(deps): bump unicode-width from 0.2.1 to 0.2.2 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2076](Automattic/harper#2076) - fix(core): detect acronyms in `AnA` by [@​86xsk](https://github.com/86xsk) in [#​2072](Automattic/harper#2072) - 2075 -- Harper Auto-submits Reddit Comments by [@​LoganBrinsmead](https://github.com/LoganBrinsmead) in [#​2079](Automattic/harper#2079) - fix(typst): fix paragraph break spans by [@​86xsk](https://github.com/86xsk) in [#​2080](Automattic/harper#2080) - feat(core): Add various new rules by [@​elijah-potter](https://github.com/elijah-potter) in [#​2084](Automattic/harper#2084) #### New Contributors - [@​LoganBrinsmead](https://github.com/LoganBrinsmead) made their first contribution in [#​2079](Automattic/harper#2079) **Full Changelog**: <Automattic/harper@v0.67.0...v0.68.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNDguNiIsInVwZGF0ZWRJblZlciI6IjQxLjE0OC42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2075
Description
The issue seems to be that the lint buttons did not have a 'type' specified, meaning they likely used the default type 'submit'. I believe that somewhere during the render process the 'submit' was triggered and was submitting the reddit comments.
Manually setting the type to 'button' fixes this and the comments no longer submit when interacting with Harper in my tests.
This PR does not yet fix the sentence copying issue although I suspect this may be occurring somewhere in replaceValue function in computeLintBoxes.ts
Demo
How Has This Been Tested?
I tested by repeatedly trying to edit reddit comments. Couldn't get any of them to submit automatically when testing this change, and Harper still seems to function normally in other applications.
Checklist