WIP: Adding correction Hotkey to Harper #2024
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return resp.hotkey; | ||
| } | ||
|
|
||
| async function setActivationKey(key: ActivationKey) { |
There was a problem hiding this comment.
It seem like there's some overlap between your work and my previous attempt with the "Activation Key" stuff. I prefer your implementation, so feel free to remove anything related to the "Activation Key" as a part of this PR.
…if last lint does not have an available suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
closes #1904
Description
This change adds a hotkey that corrects the last incorrect word as well as an option to change the hotkey in the settings menu.
To change the hotkey, click the "Modify Hotkey" button which will then listen for your hotkey change and display it in the textarea next to the button. To be abundantly clear, this is a WIP PR so far and should not be merged as there are still some issues to iron out.
Demo
Screenshot of the new option in the settings menu:
How Has This Been Tested?
Tested in blank.page where the hotkey is confirmed to correct the last incorrect word. Tests in other textboxes (like the one on Github) show that it does not yet work for rich text editors.
Checklist