test: add failing example for markdown comment parser #1948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnxpyke
force-pushed
the
fuzz/hang_markdown
branch
from
c142c71 to
88e5f67
Compare
2 tasks
|
I've gone ahead and pushed a possible fix. Would you mind doing a bit more fuzzing to confirm? |
rnxpyke
force-pushed
the
fuzz/hang_markdown
branch
from
12c7ae0 to
811948f
Compare
|
@elijah-potter the harper-core markdown parser seems fine, at least after 10_000_000 fuzzing iterations. |
| use std::thread; | ||
| use std::time::Duration; | ||
|
|
||
| let (tx, rx) = channel::<()>(); |
There was a problem hiding this comment.
Why are you doing it inside a seperate thread?
There was a problem hiding this comment.
because this is a timeout issue. the seperate thread is to not stall CI forever due to infinite-loops or similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
something similar to #1898 seems to also be an issue with the markdown parser.
Description
This is a minified version of a new fuzzing run failure on the markdown comment parser.
How Has This Been Tested?
This is the test :)
Checklist