feat: toggleable spell check rules #1895
Conversation
|
What is the consensus? Should this be enabled by default? |
I can see an argument for both. I'd maybe say disabled by default? That way it doesn't interfere with people's current Harper configs. |
@elijah-potter what do you think? |
| fn lint(&mut self, document: &Document) -> Vec<Lint> { | ||
| let mut results = Vec::new(); | ||
|
|
||
| // Check for spell check flags before running linters |
There was a problem hiding this comment.
This is another case where we're adding specialized logic to the LintGroup, which should be general. Could we set it by passing a boolean into the LintGroup::curated() method call? We could then expose config to the user as an actual checkbox (or similar).
I apologize for the back-and-forth. Thanks for responding to feedback so quickly!
There was a problem hiding this comment.
Hi! Thanks for your response! I'll see if I can implement that. Do note that I have not looked into the frontend settings config code; is there a checkbox (or similar) feature in that pipeline already?
Anyways I'll take a look and get back to you ASAP. I've got some important tests this week so it might be a bit delayed.
Description
SpellCheckIgnoreAllCapsthat configures existingSpellCheckbehavior's,'d,ed,s,es(e.g., APIs, CPUs, API'd, GPSes)"SpellCheckIgnoreAllCaps": truein their config)How Has This Been Tested?
Checklist