-
Notifications
You must be signed in to change notification settings - Fork 214
feat: reach out→contact/get in touch #1620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hippietrail
wants to merge
16
commits into
Automattic:master
Choose a base branch
from
hippietrail:dont-reach-out-please
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work-in-progress since `AnchorEnd` doesn't seem to work as expected.
…nt-reach-out-please
…nt-reach-out-please
…nt-reach-out-please
…l/harper into dont-reach-out-please
…nt-reach-out-please
…nt-reach-out-please
…nt-reach-out-please
…nt-reach-out-please
…nt-reach-out-please
…nt-reach-out-please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work-in-progress since
AnchorEnd
doesn't seem to work as expected.Issues
N/A
Description
A friend of mine hates "reach out" used instead of "contact". It turns out he is not alone:
There are different suggestions depending on "reach out to" vs "reach out for".
The case for "reach out" without either of those prepositions following is held up do to how
AnchorEnd
works...How Has This Been Tested?
I have made a bunch of unit tests from sentences from GitHub.
Checklist