feat(obsidian-plugin): added setting for whether to use Web Worker

Automattic · Dec 31, 2024 · 5f98d68 · 5f98d68
1 parent e4fbe73
commit 5f98d68
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 4 deletions.
diff --git a/packages/obsidian-plugin/src/HarperSettingTab.js b/packages/obsidian-plugin/src/HarperSettingTab.js
@@ -37,6 +37,13 @@ export class HarperSettingTab extends PluginSettingTab {
 
 		console.log(this.settings.lintSettings);
 
+		new Setting(containerEl).setName('Use Web Worker').addToggle((toggle) =>
+			toggle.setValue(this.settings.useWebWorker).onChange(async (value) => {
+				this.settings.useWebWorker = value;
+				await this.plugin.setSettings(this.settings);
+			})
+		);
+
 		for (let setting of Object.keys(this.settings.lintSettings)) {
 			let value = this.settings.lintSettings[setting];
 			let description = this.descriptions[setting];

diff --git a/packages/obsidian-plugin/src/index.js b/packages/obsidian-plugin/src/index.js
@@ -1,7 +1,7 @@
 import logoSvg from '../logo.svg';
 import { linter } from './lint';
 import { Plugin, addIcon, Menu } from 'obsidian';
-import { WorkerLinter } from 'harper.js';
+import { LocalLinter, WorkerLinter } from 'harper.js';
 import { HarperSettingTab } from './HarperSettingTab';
 
 function suggestionToLabel(sug) {
@@ -12,8 +12,20 @@ function suggestionToLabel(sug) {
 	}
 }
 
-let harper = new WorkerLinter();
-harper.setup();
+function initHarperInstance(useWebWorker) {
+	if (useWebWorker) {
+		console.log('Switching to `WorkerLinter`');
+		harper = new WorkerLinter();
+	} else {
+		console.log('Switching to `LocalLinter`');
+		harper = new LocalLinter();
+	}
+	harper.setup();
+}
+
+let harper;
+
+initHarperInstance(true);
 
 const harperLinter = (plugin) =>
 	linter(
@@ -91,7 +103,7 @@ export default class HarperPlugin extends Plugin {
 
 		let lintSettings = await harper.getLintConfig();
 
-		return { lintSettings };
+		return { ...this.settings, lintSettings };
 	}
 
 	/** @public
@@ -102,6 +114,10 @@ export default class HarperPlugin extends Plugin {
 			settings = {};
 		}
 
+		if (settings.useWebWorker == undefined) {
+			settings.useWebWorker = true;
+		}
+
 		if (settings.lintSettings == undefined) {
 			settings.lintSettings = {};
 		}
@@ -113,6 +129,12 @@ export default class HarperPlugin extends Plugin {
 		await harper.setLintConfig(settings.lintSettings);
 		this.lintSettingChanged();
 		this.saveData(settings);
+
+		if (this.settings?.useWebWorker != settings.useWebWorker) {
+			initHarperInstance(settings.useWebWorker);
+		}
+
+		this.settings = settings;
 	}
 
 	async onload() {