Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle lengths of serialized strings #39

Draft
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Commits on Feb 7, 2024

  1. Add new tests to catch issues with serialized markers

    e.g. If you have CSS in an option with `\";`, that can confuse the current way we parse stuff and lead to incorrect replacements.
    mjangda committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    622e13c View commit details
    Browse the repository at this point in the history
  2. Add additional tests for line fix function

    To help catch various edge cases
    mjangda committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    8d40ea3 View commit details
    Browse the repository at this point in the history
  3. Properly handle serialized strings

    Use the length of the serialized content to determine the scope of the search-replace action. This is to avoid problems when serialized content has a closing marker (\";), e.g. in CSS content.
    
    This is much slower and needs to be optimized.
    mjangda committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    6c08440 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Configuration menu
    Copy the full SHA
    075f58f View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Configuration menu
    Copy the full SHA
    331f65d View commit details
    Browse the repository at this point in the history