Add tests for some bad input (serialization structures)

Automattic · Oct 18, 2017 · a746956 · a746956
1 parent 3cce2d7
commit a746956
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/search-replace.go b/search-replace.go
@@ -14,7 +14,8 @@ const (
 	searchRe  = `s:\d+:\\?\".*?\\?\";`
 	replaceRe = `(?:s:)(?:\d+:)(\\?\")(.*?)(\\?\";)`
 
-	inputRe = `^[A-Za-z0-9\-\.:/]{4,}$`
+	inputRe    = `^[A-Za-z0-9\-\.:/]{4,}$`
+	badInputRe = `\w:\d+:`
 )
 
 var (
@@ -120,5 +121,10 @@ func validInput(in string) bool {
 		return false
 	}
 
+	bad := regexp.MustCompile(badInputRe)
+	if bad.MatchString(in) {
+		return false
+	}
+
 	return true
 }
diff --git a/search-replace_test.go b/search-replace_test.go
@@ -140,6 +140,21 @@ func TestInput(t *testing.T) {
 			in:       "automattic.com",
 			valid:    true,
 		},
+		{
+			testName: "Short string",
+			in:       "s:",
+			valid:    false,
+		},
+		{
+			testName: "SQL string",
+			in:       "),(",
+			valid:    false,
+		},
+		{
+			testName: "Serialization structure",
+			in:       "a:4:",
+			valid:    false,
+		},
 	}
 
 	for _, test := range tests {