Skip to content

Commit a0f60b5

Browse files
Removed another TODO and more comments on why we're shifting by 3
1 parent c8f0432 commit a0f60b5

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

search-replace.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,8 @@ func fixLineWithSerializedData(linePart []byte, replacements []*Replacement) (*S
206206
originalByteSize, _ := strconv.Atoi(string(originalBytes))
207207

208208
// the following assumes escaped double quotes
209-
//TODO: MySQL can optionally not escape the double quote,
209+
// i.e. s:5:\"x -> we'll need to shift our index from '5' to 'x' - hence shifting by 3
210+
// MySQL can optionally not escape the double quote,
210211
// but generally sqldumps always include the quotes.
211212
contentStartIndex := match[3] + 3
212213

0 commit comments

Comments
 (0)