Skip to content

Commit c8f0432

Browse files
Remove TODO and make the not-checking-for-quotes behavior something that we wanted on purpose
1 parent cbb2f61 commit c8f0432

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

search-replace.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,8 @@ var serializedStringPrefixRegexp = regexp.MustCompile(`s:(\d+):\\"`)
182182
func fixLineWithSerializedData(linePart []byte, replacements []*Replacement) (*SerializedReplaceResult, error) {
183183

184184
// find starting point in the line
185-
//TODO: We should first check if we found the string when inside a quote or not.
186-
// but currently skipping that scenario because it seems unlikely to find it outside.
185+
// We're not checking if we found the serialized string prefix inside a quote or not.
186+
// Currently skipping that scenario because it seems unlikely to find it outside.
187187
match := serializedStringPrefixRegexp.FindSubmatchIndex(linePart)
188188
if match == nil {
189189
return &SerializedReplaceResult{

0 commit comments

Comments
 (0)