Preserve textual anchors during button recognition - #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core/buttonVerification
composer testgit diff --checkFixture 37 hero CTA and footer legal links remain plain anchors; explicit styled
stream-btnand native button fixtures remain buttons.Compatibility
Detection is intentionally conservative: unstyled anchors remain links unless they declare
role=buttonor a resolved fill/border/radius surface. No commerce- or fixture-specific exceptions were added.Merge order
Blocks Engine #711 may merge first; retain both branches test additions when resolving the two expected test-file conflicts.
AI assistance
OpenAI GPT-5.6 Sol via OpenCode implemented and iteratively repaired the semantic classifier through canonical/parity review. Chris Huber reviewed and remains responsible for every line.
Fixes #709.