Skip to content

Preserve university fixture structure and visual tokens#659

Draft
chubes4 wants to merge 22 commits into
trunkfrom
fix/634-university-fixture
Draft

Preserve university fixture structure and visual tokens#659
chubes4 wants to merge 22 commits into
trunkfrom
fix/634-university-fixture

Conversation

@chubes4

@chubes4 chubes4 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • preserve native navigation row geometry, spacing, current-page state, and list alignment
  • retain linked logo/brand flex composition and standalone visual text geometry
  • preserve projected link paint, font-variant-caps, pseudo-element text shadows, and blockified flex-item link boxes
  • neutralize synthetic paragraph spacing around SVG and inline visual hosts
  • prevent stylesheet-projected SVG image-box geometry from being duplicated inside generated SVG assets

Fixes #634.

Current evidence

This remains a draft evidence PR, not a solved-site promotion.

Verified evidence:

  • The front-page run 19d7bd81-0269-4454-9662-733337370464 had zero overlap mismatch, but the candidate was 3 px taller (1280 x 3699 versus 1280 x 3696).
  • The all-route run 705aad31-551f-4ab6-8db3-a6e17e903b15 exercised all eight university routes and exposed unresolved secondary-route visual mismatches from 19.54% to 68.13%.
  • The solved 15-saas regression run b6c16b06-346f-41dd-a686-1d74beb430b7 remained pixel-identical: 0 / 9,751,080, equal 1380 x 7066 dimensions, zero fallbacks, and clean editor validity.
  • A later exploratory contact run reached 4.03%, but it included a definition-list/breadcrumb experiment that was excluded from this PR after full-suite regressions. It is diagnostic evidence only and is not claimed as validation of the pushed branch.

The pushed branch has not been rerun across all university routes after excluding that experiment. University promotion remains blocked until current-branch browser evidence reaches exact parity on every route.

Testing

  1. Check out this branch from a fresh clone.
  2. Run cd php-transformer && composer install.
  3. Run composer test.
  4. Confirm all contracts and unit tests pass, all 248 parity fixtures pass, and package-install proof passes.

Local result for commit 0b9428dc:

  • all PHP contracts and unit suites passed
  • 248 parity fixtures passed
  • package-install proof passed
  • git diff --check passed

Compatibility

These are generic HTML-to-native-block translation changes. They alter emitted block structure and generated presentation CSS for CSS-addressed inline flex/grid tokens, linked visual identities, navigation links, and generated SVG assets. Authored inline SVG declarations remain in the generated asset; declarations projected from a stylesheet remain on the native image carrier only. No fixture-specific selectors, output patches, extension paths, or public PHP API changes are introduced.

AI assistance

  • AI assistance: Yes
  • Model: OpenAI GPT-5.6 Sol
  • Tool: OpenCode
  • Used for: code investigation, implementation, test execution, conflict analysis, and browser-evidence analysis

@chubes4

chubes4 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

Current-trunk integration evidence is available at cf49a2575c5338856943f48094d3a7ca48d30ede on verify/659-font-contract.

The latest repair targets the actual marked-inline path used by .fact .fact-value. Browser evidence confirms the host paragraph now computes to zero margins. Programs improved from 26.98% to 23.84% overlap mismatch and height drift fell from +1012px to +852px; the other seven routes remained stable.

Verification is green: 248 parity fixtures, 54 author-selector tests, 89 block-style tests, Composer validation/package proof, 207/207 native imported blocks, zero core/html, and 269/269 editor-valid blocks with zero warnings.

Exact matrix inputs were SSI 6b761e5042cef225e985cf827566c30f3481a9ec, WP Codebox 2563caec3c41e4f1dd695dd0ed39fc562aa0f380, transformer cf49a2575c5338856943f48094d3a7ca48d30ede, and --surface-coverage 7.

SSI_FIXTURE_MATRIX_WP_CODEBOX_BIN="$WP_CODEBOX/bin/wp-codebox-source.mjs" node "$SSI/bench/static-site-fixture-matrix.bench.mjs" "$BLOCKS_ENGINE/fixtures/websites/27-university-department" --output-directory "$OUT" --static-site-importer-path "$SSI" --blocks-engine-php-transformer-path "$BLOCKS_ENGINE/php-transformer" --blocks-engine-php-transformer-reference cf49a2575c5338856943f48094d3a7ca48d30ede --surface-coverage 7 --run

This does not make the draft mergeable. PR #659 remains broad, stale, and conflicting. The next isolated cause is shared multi-page .chip CSS applying source chrome to the native outer core/button wrapper while projected CSS applies it again to the inner button. On faculty this creates the first +18.34px offset (30px source chip versus 48.34px candidate wrapper). The next extraction should solve shared stylesheet control projection generically and preserve runtime selector behavior.

@chubes4

chubes4 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Validated work from this evidence branch has been split onto current trunk for independent review:

Remaining generic follow-ups are tracked in #699, #700, #701, and #702. Downstream materialization work is tracked in Static Site Importer #732, #733, and #734. This PR remains the broader university evidence branch rather than the landing vehicle for those slices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Solve 27-university-department fixture against the released corpus gate

1 participant