Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope module assets ( v2 ) #487

Closed
wants to merge 41 commits into from
Closed

Scope module assets ( v2 ) #487

wants to merge 41 commits into from

Commits on Jan 29, 2018

  1. Add method is_module_view

    Norris committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    435447b View commit details
    Browse the repository at this point in the history

  2. Deprecate is_whitelisted_settings_view() in favor of `is_module_set… 

    …tings_view()`
    Norris committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    970c89e View commit details
    Browse the repository at this point in the history

  3. Add style & script interfaces to improve method name consistency

    Norris committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    89206dc View commit details
    Browse the repository at this point in the history

  4. Add Edit_Flow_Module_With_View interface

    Norris committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    e0c2aef View commit details
    Browse the repository at this point in the history

  5. Accept $module_name in is_module_settings_view

    Norris committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    bf67dcb View commit details
    Browse the repository at this point in the history

  6. Refactor calendar asset enqueuing

    Norris committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    9b2698a View commit details
    Browse the repository at this point in the history

  7. Refactor custom-status asset enqueuing

    Norris committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    a46ed47 View commit details
    Browse the repository at this point in the history

  8. Deprecate is_whitelisted_functional_view() method 

    Even though this method was never implemented - deprecate it, in case someone is relying on it
    Norris committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    ab8bdef View commit details
    Browse the repository at this point in the history

  9. Pull method up & rename it to is_module_edit_view() for reusability 

    Rename `disable_custom_statuses_for_post_type` to `is_module_edit_view`
    Norris committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    49b7a9b View commit details
    Browse the repository at this point in the history

  10. Refactor notification asset enqueuing

    Norris committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    3785a7f View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2018

  1. Use is_module_settings_view() instead of `is_whitelisted_settings_v… 

    …iew()`
    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    55d435b View commit details
    Browse the repository at this point in the history

  2. Improve function naming: is_module_edit_view -> is_active_view

    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    8a0ca71 View commit details
    Browse the repository at this point in the history

  3. Add is_current_module_settings_view to help easily target the curre… 

    …nt module
    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    b70164f View commit details
    Browse the repository at this point in the history

  4. Rename is_current_module_view to is_calendar_view

    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    bd4885d View commit details
    Browse the repository at this point in the history

  5. Remove is_module_view() method because it’s no longer used

    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    4e17907 View commit details
    Browse the repository at this point in the history

  6. Improve custom status is_current_module_view method

    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    64abafa View commit details
    Browse the repository at this point in the history

  7. Refactor editorial metadata asset enqueuing

    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    98aabcd View commit details
    Browse the repository at this point in the history

  8. Notification assets are only needed in settings and active editor view

    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    e938ca2 View commit details
    Browse the repository at this point in the history

  9. Refactor user groups asset enqueuing

    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    65aca1e View commit details
    Browse the repository at this point in the history

  10. Improve comment at is_whitelisted_functional_view method

    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    cdce333 View commit details
    Browse the repository at this point in the history

  11. Move deprecated methods down

    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    eecb486 View commit details
    Browse the repository at this point in the history

  12. Rename is_current_module_view() to is_custom_status_view()

    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    bb31689 View commit details
    Browse the repository at this point in the history

  13. Remove unused Edit_Flow_Module_With_View interface

    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    f8fd8f1 View commit details
    Browse the repository at this point in the history

  14. Use is_current_module_settings_view method instead of is_module_setti… 

    …ngs_view( $this->module->name )
    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    3ce044f View commit details
    Browse the repository at this point in the history

  15. Merge branch 'master' of https://github.com/Automattic/Edit-Flow into… 

    … fix-351-scope-assets
    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    ec35e5b View commit details
    Browse the repository at this point in the history

  16. Use is_custom_status_view to check if is active view 

    Instead of a plain `is_active_view()`
    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    496ce93 View commit details
    Browse the repository at this point in the history

  17. Extract a EF_Module_With_View trait

    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    9c9da87 View commit details
    Browse the repository at this point in the history

  18. Utilize trait EF_Module_With_View

    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    accc76c View commit details
    Browse the repository at this point in the history

  19. Refactor story budget asset enqueuing

    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    23a6a3c View commit details
    Browse the repository at this point in the history

  20. Rename Edit_Flow_**** to EF_****_Interface

    Norris committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    d9862ef View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2018

  1. Update comments

    Norris committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    dac767f View commit details
    Browse the repository at this point in the history

  2. Call a Trait a Trait

    Norris committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    79eda84 View commit details
    Browse the repository at this point in the history

  3. Add more comments

    Norris committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    96387f0 View commit details
    Browse the repository at this point in the history

  4. Remove Trait, use regular Classes instead

    Norris committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    dc9bf6b View commit details
    Browse the repository at this point in the history

  5. Check for module settings view in EF_Custom_Status

    Norris committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    235ae9e View commit details
    Browse the repository at this point in the history

  6. Refactor editorial comments asset enqueuing

    Norris committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    b470e94 View commit details
    Browse the repository at this point in the history

  7. Set the post_type to post if edit.php OR post-new.php

    Norris committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    cfbca15 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2018

  1. Merge branch 'master' of https://github.com/Automattic/Edit-Flow into… 

    … fix-351-scope-assets
    Norris committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    a38177c View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2018

  1. Merge branch 'master' of https://github.com/Automattic/Edit-Flow into… 

    … fix-351-scope-assets
    Norris committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    2de212d View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2018

  1. Merge branch 'fix-351-scope-assets' of github.com:justnorris/Edit-Flo… 

    …w into scope-module-assets

# Conflicts:
#	modules/calendar/calendar.php
#	modules/custom-status/custom-status.php
#	modules/editorial-comments/editorial-comments.php
    Nauris committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    9da539a View commit details
    Browse the repository at this point in the history

  2. Change the test to test only the view 

    This fixes the test errors that happened after migrating most of the methods away from EF_Module to EF_Module_With_View

Changed the class used in tests from `EF_Module` to `EF_Module_With_view`

The test only tests a module with a view, not a generic Edit_Flow module.
    Nauris committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    3228baf View commit details
    Browse the repository at this point in the history