Skip to content

Scene System Testing [AARD-1938] #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

AlexD717
Copy link
Member

Task

Create unit tests for each element found in fission/src/systems/scene/.

AARD-1938

Symptom

No unit tests currently exist for elements in fission/src/systems/scene/.

Solution

Create unit test for each element in fission/src/systems/scene/.
Note: No unit tests were created for SceneObject.ts due to it being very simple and other tests already testing its functionality.

Verification

All unit tests pass


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@AlexD717 AlexD717 self-assigned this Jul 15, 2025
@AlexD717 AlexD717 requested review from a team as code owners July 15, 2025 21:30
@AlexD717 AlexD717 marked this pull request as draft July 15, 2025 21:35
@AlexD717 AlexD717 marked this pull request as ready for review July 15, 2025 21:53
Copy link
Member

@rutmanz rutmanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only about halfway done reading through this but I'm concerned that a lot of the tests here aren't really checking for things that matter. Like #1179, it kind of feels like these might be AI generated, and I'm not sure what a lot of them are doing

@AlexD717
Copy link
Member Author

I'm only about halfway done reading through this but I'm concerned that a lot of the tests here aren't really checking for things that matter. Like #1179, it kind of feels like these might be AI generated, and I'm not sure what a lot of them are doing

I did use AI to help make these unit tests, and I thought that I looked through them and fixed all the mistakes. I have clearly missed some, so I will go through again and double check that everything is good.

@AlexD717 AlexD717 marked this pull request as draft July 16, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants