-
Notifications
You must be signed in to change notification settings - Fork 62
Scene System Testing [AARD-1938]
#1217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only about halfway done reading through this but I'm concerned that a lot of the tests here aren't really checking for things that matter. Like #1179, it kind of feels like these might be AI generated, and I'm not sure what a lot of them are doing
I did use AI to help make these unit tests, and I thought that I looked through them and fixed all the mistakes. I have clearly missed some, so I will go through again and double check that everything is good. |
Task
Create unit tests for each element found in
fission/src/systems/scene/
.AARD-1938
Symptom
No unit tests currently exist for elements in
fission/src/systems/scene/
.Solution
Create unit test for each element in
fission/src/systems/scene/
.Note: No unit tests were created for SceneObject.ts due to it being very simple and other tests already testing its functionality.
Verification
All unit tests pass
Before merging, ensure the following criteria are met: