Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a few problems with advanced brep export and propose these fixes for them.
Fixed inconsistent mapping of Revit coordinates to IFC coordinates in export of RuledFace, arcs and ellipses.
Improved logic that organizes the inner and outer loops of a Face and fixed an orientation problem for inner loops.
I uploaded 3 sample .rvt files in the attached FaceLoopProblems.zip. One of the problems is incorrect loop orientation of inner loops. The problems occur when exporting these in IFC 4 Design Transfer View. E.g. this is one of the faces from the export of PaneledCabinet.rvt. The blue loop is the outer face loop and the red ones are the inner loops. The inner loops have the same orientation as the outer loop, which is wrong.
This is with the fixes:
From the same sample file: some Revit faces are split in multiple IFC faces, because of incorrect loop nesting detection. This is a face with one outer and one inner loop as exported by the current exporter. The result is two separate IFC faces, each with one outer loop:
With the fixes, we get a single face with an outer loop and an inner loop:
FaceLoopProblems.zip