Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui settings fixes #235

Closed
wants to merge 3 commits into from
Closed

Ui settings fixes #235

wants to merge 3 commits into from

Conversation

bmznti
Copy link

@bmznti bmznti commented Oct 19, 2020

There are 2 dialogs where settings are not saved/read for further use.

If you create a custom setting like "Setup 1" and change the "Coordinate Base" setting it don't remember the setting after export and close.
When you open the export dialog again the setting is set back to "Coordinate Base" = "Shared Coordinates".
This pull request fixes this issue and it saves/reads the changes user made.
I have marked the setting on the dialog on next picture.
image

The 2 marked settings on the next picture have same issue, they don't save changes user have made. The name of the settings are "Assign address to building" and "Assign address to site".
The setting "Assign address to building" always have checkmark set in the dialog and don't remember if user uncheck it.
The setting "Assign address to site" always have unchecked checkmark in the dialog and don't remember if user have checked it.
The pull request saves/read the settings user have made when dialog is opend again.
image

bmznti added 3 commits July 6, 2020 15:31
Now "Coordinate Base" settings get loaded when user change away from default "Shared Coordinates".
…e checkmark state. Databinding is added to "Update project information", "Assign adress to building" and "Assign address to site" instad of check/uncheck events.

Fixed missing save settings on "Project Address" dialog
@PeterTranberg
Copy link

@AngelVelezSosa is this going to be part of the next version 2020 and 2021?
/PT

@PeterTranberg
Copy link

@WawanSolihin - is this going to be part of the next version 2020 and 2021?
/PT

@PeterTranberg
Copy link

@AngelVelezSosa and @WawanSolihin Can you say anything about the plans to include our code in this pullrequest?
/PT

@WawanSolihin
Copy link
Contributor

I will take a look. I think the coordinate base is already remembered in the latest IfcExporter. Left the "Assign address to .." that is still not remembered.

@PeterTranberg
Copy link

I will take a look. I think the coordinate base is already remembered in the latest IfcExporter. Left the "Assign address to .." that is still not remembered.

Thanks, I found that the Coordinate Base is saved and loaded, so thats fixed :-)

@ArtemHnatko
Copy link

Thank you for reporting this issue and providing detailed feedback. I wanted to provide an update regarding the behavior of the settings in Revit 2023-2025.

After thorough testing, I can confirm that the described issue is no longer reproducible in the latest versions of Revit (2023-2025). Specifically:

  1. The "Coordinate Base" setting is now correctly saved and loaded within the session.

  2. The "Assign address to building" and "Assign address to site" settings are also properly retained during the session.

Additionally, these settings are consistently applied across all newly created or opened projects within the same Revit session. This improvement ensures a more seamless user experience when working with custom configurations.

If anyone encounters further issues or inconsistencies, please feel free to share additional details, and we’ll be happy to investigate further.

Thank you again for your contributions and collaboration!

@o-babii o-babii closed this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants