OGSMOD-7679 - Create a 'TestFramework' public library #26
Conversation
hodoulp
force-pushed
the
hodoulp/create_lib_1
branch
from
c4f6e63 to
e5727d1
Compare
|
|
||
| /// An instance of this class will set the baseline folder to the given path and restore the | ||
| /// previous one when it goes out of scope. | ||
| class ScopedBaselineContextFolder |
There was a problem hiding this comment.
Will this be moved internally?
| @@ -1,15 +1,19 @@ | |||
| // Copyright 2025 Autodesk, Inc. | |||
There was a problem hiding this comment.
Overall comment - really like this approach. Thanks for tackling it.
Semi-minor: Can we rename this impl folder to TestFramework (testFramework?); and should the namespace be testFramework instead of TestFramework?
There was a problem hiding this comment.
Renamed testHelpers.* to testFramework.* but not convinced about the directory
There was a problem hiding this comment.
🤔 Why wouldn't the source directory be named consistent with the include directory? ie. test/testFramework/...
There was a problem hiding this comment.
I don't remember why but there are two libraries part of the Unit Test Framework and I do not want this internal implementation be visible in the public API. If this proposal is finally the right one, I will perhaps merge these two libraries.
| @@ -0,0 +1,36 @@ | |||
| // Copyright 2025 Autodesk, Inc. | |||
There was a problem hiding this comment.
Do headers have different copyright comments from implementations files? I can't remember for hvt.
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
hodoulp
force-pushed
the
hodoulp/create_lib_1
branch
from
1ff8296 to
20086d3
Compare
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
The pull request creates a library from
RenderingFrameworkRenderingUtilswith a restricted public API to let other projects have access to thisUnit Test Framework.