Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

Deprecate CoroutineWorker, enable the new Memory Model #99

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

C2H6O
Copy link
Contributor

@C2H6O C2H6O commented Aug 3, 2022

With the release of Kotlin 1.7.20-Beta (https://blog.jetbrains.com/kotlin/2022/08/kotlin-1-7-20-beta/) and the new
Memory Model for Kotlin Native becoming the default, there's no longer a need for this library. Version 0.9.0 helps
transition over to the new memory model without having to make any changes related to CoroutineWorker code. The latest
version of CoroutineWorker uses the same implementation for all platforms.

@DanielRBaird
Copy link
Contributor

As we discussed elsewhere, I think the plan will be to merge this to a separate branch and create a special deprecation release that people can grab if they want to migrate away without dealing with pulling the library out immediately.

@benasher44
Copy link
Contributor

IMO, we should push people to the new memory model, if it's stable.

@DanielRBaird
Copy link
Contributor

IMO, we should push people to the new memory model, if it's stable.

I believe that it is stable, and generally agree. Are you just suggesting that we should make the deprecation version the primary branch?

We are currently discussing how that branching is going to work exactly. The only things we know for sure is that we want to have a separate branch for support purposes for old things, and we probably want to publish the deprecation version with a name such that people won't update to it accidentally, and will realize they aren't meant to keep it around. It will only exist to make the transition easier.

@benasher44
Copy link
Contributor

I think we should publish 1.0.0, so it's clearly breaking. Upgrading requires the new memory model. If someone needs maintenance of the existing version that supports the old memory model, we can publish new versions after they make their case via a GitHub issue.

@DanielRBaird
Copy link
Contributor

I think we should publish 1.0.0, so it's clearly breaking. Upgrading requires the new memory model. If someone needs maintenance of the existing version that supports the old memory model, we can publish new versions after they make their case via a GitHub issue.

Sounds reasonable to me.

Memory Model for Kotlin Native becoming the default, there's no longer a need for this library. Version 0.9.0 helps
transition over to the new memory model without having to make any changes related to CoroutineWorker code. The latest
version of CoroutineWorker uses the same implementation for all platforms.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe just leave the documentation below set to the last version that did things differently, and tell people to just use the latest version only if they are using the new memory model?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait why are we doing a 0.9.0 again? I thought we were gonna do 1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants