Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External navigation interface #5

Merged
merged 44 commits into from
Dec 4, 2023
Merged

External navigation interface #5

merged 44 commits into from
Dec 4, 2023

Conversation

GuillaumeLaine
Copy link
Member

@GuillaumeLaine GuillaumeLaine commented Nov 20, 2023

Contents:

  • Local navigation interface
  • Example usage node of local navigation interface
  • Global navigation interface
  • Example usage node of global navigation interface

Testing

  • Flight tested by passing lat lon measurements to the global interface from vehicle_gps_position plus noise, and checking aux global position was fused in the EKF.
  • Flight tested by passing 3D local position measurements to the local interface from vehicle_local_position plus noise, and checking external vision position was fused in the EKF.

Usage

Build, source, run local interface example node which uses the interface to send a sample estimate every 1s:

ros2 run example_local_navigation_cpp example_local_navigation_cpp

Similarly for global interface example node:

 ros2 run example_global_navigation_cpp example_global_navigation_cpp

@GuillaumeLaine GuillaumeLaine marked this pull request as draft November 20, 2023 12:23
Copy link
Contributor

@DanMesh DanMesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is off to a good start. I looked mostly at the local updates for now and left a few thoughts.

Copy link
Contributor

@DanMesh DanMesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Looking forward to some flight tests for validation 🛩️

@GuillaumeLaine GuillaumeLaine marked this pull request as ready for review November 24, 2023 13:04
Copy link
Collaborator

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I remarked a couple of smaller things.

Copy link
Contributor

@DanMesh DanMesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The aux global position PR is merged, so this should be ready to go

@DanMesh DanMesh requested a review from bkueng December 1, 2023 11:20
@GuillaumeLaine GuillaumeLaine requested a review from bresch December 1, 2023 14:21
Comment on lines 20 to 33
enum class PoseFrame
{
Unknown,
LocalNED,
LocalFRD
};

enum class VelocityFrame
{
Unknown,
LocalNED,
LocalFRD,
BodyFRD
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you either:

  • move these into the class LocalPositionMeasurementInterface
  • or make them more generally available by moving them into a common header frame.hpp? And then you could use a single enum.

Otherwise there will be a conflict if another component wants to define these as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create a common header so that it's more widely available.
However, since they are slightly different, I'd be inclined to keep them as two separate enums.

@DanMesh DanMesh requested a review from bkueng December 4, 2023 11:25
Copy link
Collaborator

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in - I'm squashing the commits.

@bkueng bkueng merged commit 561a8f1 into Auterion:main Dec 4, 2023
1 of 2 checks passed
@DanMesh
Copy link
Contributor

DanMesh commented Dec 4, 2023

Great, thanks @bkueng!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants