Conversation
Additionally IssueDetails (Bounty widget) and Issue Card needed to notice bounty's expiration and show appropriate information, as per Figma design and this ticket: #1797
chadoh
left a comment
There was a problem hiding this comment.
BountyContextMenu for expired bounties reverts to 'Fund issue'. It opens "bounty update" form (alternative solution: it could perform removing bounty first, one additional transaction). Currently it's returning "not enough permissions" upon submitting - not sure if it is my setup, or... in any case it needs some further testing.
I want to get input from @topocount or @Quazia or @ottodevs on this before we merge. Also, what method did you use to test this?
I tested locally and everything seems to work pretty well, other than the above, which I couldn't figure out how to test without waiting 24 hours. I did note some small code cleanup that I'd like to see before we merge, too.
chadoh
left a comment
There was a problem hiding this comment.
The code looks good to me, but please wait for an approving review from @Quazia / @topocount / @ottodevs before merging
|
There is more to this. Namely: what exactly should and can happen after a bounty expires. |

Additionally IssueDetails (Bounty widget) and Issue Card needed to notice bounty's expiration and show appropriate information, as per Figma design. Screens of the Issue Card:
Not completed:
Bounty in progress, number information added (1 bounty is the default and only option right now):
Bounty completed (reduction in number of items):
Bounty widget past due date without submissions:
Bounty widget past due date with submissions (panels open in RO mode):
BountyContextMenu for expired bounties reverts to 'Fund issue'. It opens "bounty update" form (alternative solution: it could perform removing bounty first, one additional transaction). Currently it's returning "not enough permissions" upon submitting - not sure if it is my setup, or... in any case it needs some further testing.