Projects/App.js: memoize all the things#1703
Open
chadoh wants to merge 1 commit intofilterbar-contextfrom
Open
Projects/App.js: memoize all the things#1703chadoh wants to merge 1 commit intofilterbar-contextfrom
chadoh wants to merge 1 commit intofilterbar-contextfrom
Conversation
We do not need or want to recalculate all of this stuff on every render of App.js. In particular, this caused the entire Tabs bar and TabAction (with associated MiniFilterBar) to be removed from the DOM and re-added on every render.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not need or want to recalculate all of this stuff on every render
of App.js. In particular, this caused the entire Tabs bar and TabAction
(with associated MiniFilterBar) to be removed from the DOM and re-added
on every render.
To do before merge:
dev