Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust.php #698

Closed
wants to merge 1 commit into from
Closed

Update Rust.php #698

wants to merge 1 commit into from

Conversation

ce-ju
Copy link

@ce-ju ce-ju commented Mar 13, 2023

Server Port + 1 = Query Port

Server Port + 1 = Query Port
@ce-ju ce-ju mentioned this pull request Mar 13, 2023
@scrutinizer-notifier
Copy link

The inspection completed: No new issues

*/
protected function processDetails(Buffer $buffer)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for removing this function?

Copy link
Author

@ce-ju ce-ju Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the function I have no online status, maybe you can test it too?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Rust follows the regular source response for player information now. Without the processDetails function both max_players and num_players have values. Was able to find a server to test on that responded at 95.214.180.237:28067 using query_port+1.

@Austinb
Copy link
Owner

Austinb commented Mar 28, 2023

Assuming the conversation around processDetails is satisfied, code style needs to be fixed so tests will pass.

@Austinb Austinb added Bug This request does fix a bug. v3 labels Mar 28, 2023
@Austinb Austinb added this to the v3.1.1 milestone Mar 28, 2023
@ce-ju ce-ju closed this by deleting the head repository Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This request does fix a bug. v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants