Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Raknet protocol class with Minecraft Bedrock Edition protocol. #657

Merged
merged 7 commits into from
Feb 25, 2023

Conversation

Austinb
Copy link
Owner

@Austinb Austinb commented Aug 29, 2022

Only real game used with this. Normalize still needs tweaking.

@coveralls
Copy link

coveralls commented Aug 29, 2022

Coverage Status

Coverage decreased (-0.2%) to 88.373% when pulling e9bd2e7 on features/MInecraftBE_Raknet into 44e7906 on v3.

@Austinb
Copy link
Owner Author

Austinb commented Aug 29, 2022

This is for #642. Needs checking of the normalize response. Might need to add a bit more testing around the whole magic query business which is just a bit odd.

Austinb and others added 2 commits August 28, 2022 23:35
@Austinb Austinb force-pushed the features/MInecraftBE_Raknet branch from b641fcf to 6d039bc Compare August 29, 2022 04:37
@Austinb
Copy link
Owner Author

Austinb commented Aug 29, 2022

Sorry for the force push, had the wrong information for my signature. Will be fixed moving forward.

@Austinb Austinb added Feature Request v3 Enhancement This request does add something to the project. labels Aug 29, 2022
@Erani0
Copy link
Contributor

Erani0 commented Aug 29, 2022

This is for #642. Needs checking of the normalize response. Might need to add a bit more testing around the whole magic query business which is just a bit odd.

I'll test it in detail later and if there's an error I'll write something about it

@Austinb
Copy link
Owner Author

Austinb commented Aug 29, 2022

This is for #642. Needs checking of the normalize response. Might need to add a bit more testing around the whole magic query business which is just a bit odd.

I'll test it in detail later and if there's an error I'll write something about it

Sounds good. Will finish up the testing as well once there are other tweaks that need to be made. Also, the server tests may need to be rebuilt.

@bumbummen99 bumbummen99 added this to the v3.1.1 milestone Aug 29, 2022
@Erani0
Copy link
Contributor

Erani0 commented Aug 30, 2022

So I tested it with a couple of public servers and it seems that there are servers that do not transmit the port_ipv4 and port_ipv6 port then it comes to the following error message
Warning: Undefined array key 10 in /var/www/pterodactyl/public/test/GameQ/Protocols/Raknet.php on line 156

Warning: Undefined array key 11 in /var/www/pterodactyl/public/test/GameQ/Protocols/Raknet.php on line 157

And on none of the tested servers the player list can be displayed. Maybe this can be changed.

@Austinb
Copy link
Owner Author

Austinb commented Aug 30, 2022

So I tested it with a couple of public servers and it seems that there are servers that do not transmit the port_ipv4 and port_ipv6 port then it comes to the following error message Warning: Undefined array key 10 in /var/www/pterodactyl/public/test/GameQ/Protocols/Raknet.php on line 156

Warning: Undefined array key 11 in /var/www/pterodactyl/public/test/GameQ/Protocols/Raknet.php on line 157

Please send the IP addresses and ports for those servers so I can add them as tests. Need to make sure this class does not emit any kind of warnings/notices.

And on none of the tested servers the player list can be displayed. Maybe this can be changed.

Please check the Raknet protocol documents - the link is in the header of the Raknet.php file. There is no information on gathering player information other than current and maximum player counts.

@Erani0
Copy link
Contributor

Erani0 commented Aug 30, 2022

this is a public Bedrock server with 15K+ Player
151.80.79.246:19132

to test I have the following now in it so that no error is displayed

        $result->add('port_ipv4', isset($info[10]) ? (int)$info[10] : 0);
        $result->add('port_ipv6', isset($info[11]) ? (int)$info[11] : 0);

@scrutinizer-notifier
Copy link

The inspection completed: 4 updated code elements

@Austinb Austinb self-assigned this Feb 25, 2023
@Austinb Austinb merged commit a4d27e0 into v3 Feb 25, 2023
@Austinb Austinb deleted the features/MInecraftBE_Raknet branch February 25, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This request does add something to the project. Feature Request v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants