-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Raknet protocol class with Minecraft Bedrock Edition protocol. #657
Conversation
This is for #642. Needs checking of the normalize response. Might need to add a bit more testing around the whole magic query business which is just a bit odd. |
…ly real game used with this. Normalize still needs tweaking.
b641fcf
to
6d039bc
Compare
Sorry for the force push, had the wrong information for my signature. Will be fixed moving forward. |
I'll test it in detail later and if there's an error I'll write something about it |
Sounds good. Will finish up the testing as well once there are other tweaks that need to be made. Also, the server tests may need to be rebuilt. |
So I tested it with a couple of public servers and it seems that there are servers that do not transmit the port_ipv4 and port_ipv6 port then it comes to the following error message Warning: Undefined array key 11 in /var/www/pterodactyl/public/test/GameQ/Protocols/Raknet.php on line 157 And on none of the tested servers the player list can be displayed. Maybe this can be changed. |
Please send the IP addresses and ports for those servers so I can add them as tests. Need to make sure this class does not emit any kind of warnings/notices.
Please check the Raknet protocol documents - the link is in the header of the Raknet.php file. There is no information on gathering player information other than current and maximum player counts. |
this is a public Bedrock server with 15K+ Player to test I have the following now in it so that no error is displayed
|
…if undefined. Add extra test with server not returning either value.
…wn to match rest of the library's error messages.
The inspection completed: 4 updated code elements |
Only real game used with this. Normalize still needs tweaking.