Skip to content

Fix track overflow menu showing delete action in playlist edit context#14098

Merged
dylanjeffers merged 1 commit intomainfrom
cursor/bug-report-resolution-e4b7
Apr 10, 2026
Merged

Fix track overflow menu showing delete action in playlist edit context#14098
dylanjeffers merged 1 commit intomainfrom
cursor/bug-report-resolution-e4b7

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor bot commented Apr 10, 2026

Summary

  • hide Delete Track from the track overflow menu when the menu is being used in collection page remove-flow context (onRemove present)
  • keep Delete Track available in other contexts

Root Cause

  • the table overflow menu for collection pages injects a contextual "Remove from this playlist/album" item, but still relied on TrackMenu default includeDelete=true
  • this caused owners to see both remove and delete in the same menu, making accidental destructive deletes possible

Testing

  • attempted focused web test run: npm run -w packages/web test -- --runInBand OverflowMenuButton
  • environment limitation: vitest: not found in this workspace
Open in Web View Automation 

Co-authored-by: Ray Jacobson <raymondjacobson@users.noreply.github.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 10, 2026

⚠️ No Changeset found

Latest commit: f16a35e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

🌐 Web preview ready

Preview URL: https://audius-web-preview-pr-14098.audius.workers.dev

Unique preview for this PR (deployed from this branch).
Workflow run

@rickyrombo rickyrombo requested a review from Copilot April 10, 2026 17:06
@rickyrombo rickyrombo marked this pull request as ready for review April 10, 2026 17:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents the track overflow menu in collection edit/remove flows from showing both “Remove” and the destructive “Delete Track” action, reducing the risk of accidental deletes while preserving delete availability elsewhere.

Changes:

  • Plumbs includeDelete through OverflowMenuButton and conditionally disables it when onRemove is present.
  • Keeps existing edit/menu behavior unchanged in non-remove contexts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dylanjeffers dylanjeffers merged commit 0a737dc into main Apr 10, 2026
18 checks passed
@dylanjeffers dylanjeffers deleted the cursor/bug-report-resolution-e4b7 branch April 10, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants