Fix track overflow menu showing delete action in playlist edit context#14098
Fix track overflow menu showing delete action in playlist edit context#14098dylanjeffers merged 1 commit intomainfrom
Conversation
Co-authored-by: Ray Jacobson <raymondjacobson@users.noreply.github.com>
|
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14098.audius.workers.dev Unique preview for this PR (deployed from this branch). |
There was a problem hiding this comment.
Pull request overview
This PR prevents the track overflow menu in collection edit/remove flows from showing both “Remove” and the destructive “Delete Track” action, reducing the risk of accidental deletes while preserving delete availability elsewhere.
Changes:
- Plumbs
includeDeletethroughOverflowMenuButtonand conditionally disables it whenonRemoveis present. - Keeps existing edit/menu behavior unchanged in non-remove contexts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Delete Trackfrom the track overflow menu when the menu is being used in collection page remove-flow context (onRemovepresent)Delete Trackavailable in other contextsRoot Cause
TrackMenudefaultincludeDelete=trueTesting
npm run -w packages/web test -- --runInBand OverflowMenuButtonvitest: not foundin this workspace