Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Help command aliases #306

Merged
merged 6 commits into from
Jul 6, 2022
Merged

WIP: Help command aliases #306

merged 6 commits into from
Jul 6, 2022

Conversation

cow-face
Copy link
Contributor

@cow-face cow-face commented Jul 3, 2022

Resolves #290

in1tiate
in1tiate previously requested changes Jul 3, 2022
View reviewed changes
Copy link
Member

@in1tiate in1tiate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some minor problems to address, but this looks fine otherwise

bin/config_sample/text/commandhelp.json Show resolved Hide resolved
bin/config_sample/text/commandhelp.json Outdated Show resolved Hide resolved
bin/config_sample/text/commandhelp.json Outdated Show resolved Hide resolved
bin/config_sample/text/commandhelp.json Outdated Show resolved Hide resolved
bin/config_sample/text/commandhelp.json Outdated Show resolved Hide resolved
bin/config_sample/text/commandhelp.json Show resolved Hide resolved
mposs00
mposs00 requested changes Jul 3, 2022
View reviewed changes
core/src/config_manager.cpp Outdated Show resolved Hide resolved
core/src/config_manager.cpp Outdated Show resolved Hide resolved
@mposs00
Copy link
Collaborator

mposs00 commented Jul 6, 2022

fails tests

FAIL!  : tests::unittests::tst_ConfigManager::CommandInfo() Compared values are not the same
   Actual   (l_help.text)            : ""
   Expected ("A sample explanation."): A sample explanation.
   Loc: [tst_unittest_config_manager.cpp(221)]```

@mposs00
Copy link
Collaborator

mposs00 commented Jul 6, 2022

windows will be fine, pending #300

@mposs00
Copy link
Collaborator

mposs00 commented Jul 6, 2022

approved pending #300 and tests

@mposs00 mposs00 merged commit 03ee933 into AttorneyOnline:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mposs00 mposs00 mposs00 approved these changes

@in1tiate in1tiate in1tiate left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/help doesn't acknowledge aliases
3 participants
@cow-face @mposs00 @in1tiate