Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropped feature list, introduced protocol version, ... #1004

Closed
wants to merge 8 commits into from
Closed

Dropped feature list, introduced protocol version, ... #1004

wants to merge 8 commits into from

Conversation

TrickyLeifa
Copy link
Contributor

Resolve #988

  • Dropped feature list
  • Introduced protocol version
  • Bumped version to 2.11.0

@TrickyLeifa
Dropped feature list, introduced protocol version, ...
6321050 
Resolve #988

* Dropped feature list
* Introduced protocol version
* Bumped version to 2.11.0
@TrickyLeifa TrickyLeifa added enhancement Request for functionality not present internal For internal changes that do not affect the user maintenance labels Jul 5, 2024
@Salanto
Copy link
Contributor

Salanto commented Jul 9, 2024

While it can join servers, it does not display the playercount anymore. I presume its the extra arg on the ID packet.
We might not want to break THAT specific aspect of Lobby just yet as it will make the client seem non-functional.
image

in1tiate
in1tiate previously approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@in1tiate in1tiate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative approval pending review from @Salanto and testing

@in1tiate in1tiate requested a review from Salanto July 10, 2024 14:02
@stonedDiscord
Copy link
Member

the playercount doesn't work

stonedDiscord
stonedDiscord previously requested changes Jul 10, 2024
View reviewed changes
src/packet_distribution.cpp Outdated Show resolved Hide resolved
Salanto and others added 3 commits July 10, 2024 22:38
@Salanto
Merge branch 'master' into featureless
49f7137
@TrickyLeifa
Tweaked logic for packet size checks,
e484d00 
* Tweaked logic for packet size checks
* RT packet requires at least two arguments for consistency
@TrickyLeifa
Merge branch 'featureless' of https://github.com/AttorneyOnline/AO2-C…
647e0be 
…lient into featureless
@Salanto Salanto linked an issue Jul 12, 2024 that may be closed by this pull request
FL, Versioning and the bane of compatability #870
Open
@TrickyLeifa TrickyLeifa dismissed stonedDiscord’s stale review July 13, 2024 08:50

Changes to the protocol is a required step to properly drop feature list.

@TrickyLeifa TrickyLeifa deleted the featureless branch July 16, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@in1tiate in1tiate in1tiate approved these changes

@Salanto Salanto Salanto approved these changes

@stonedDiscord stonedDiscord stonedDiscord left review comments

Assignees
No one assigned
Labels
enhancement Request for functionality not present internal For internal changes that do not affect the user maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop feature list FL, Versioning and the bane of compatability
4 participants
@TrickyLeifa @Salanto @stonedDiscord @in1tiate