Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low hanging performance fixes and some comment cleanup #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Low hanging performance fixes and some comment cleanup #4

wants to merge 4 commits into from

Commits on Dec 7, 2021

  1. Bump dependencies and move allocations outside of the hotpath 

    Clean up some old code comments that were distracting

Use a new factorization algorithm so that the tests actually finish. This will make working much less tedious.
    Evan Hines committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    032886a View commit details
    Browse the repository at this point in the history

  2. Fix bug in small prime factor code. For some reason it would check mo… 

    …dulus the prime and return maybe prime although we can just as easily check if it actually that prime right here. This was causing small primes to go through the more expensive primality tests although we didn't need to.

Add a test for factoring two prime numbers
    Evan Hines committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    92ae30f View commit details
    Browse the repository at this point in the history

  3. Remove commented out no_std

    Evan Hines committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    1bd4baa View commit details
    Browse the repository at this point in the history

  4. Fall back to brute force factorization in cases where rho fails to fi… 

    …nd a solution.
    Evan Hines committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    a83a76c View commit details
    Browse the repository at this point in the history