This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
config: use atom defaults for missing local keys #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a local config in projects, the linter assumes every key is defined and has a value. Especially if "execPath" is not set in the local config, linter-gcc trips and produces stack traces like the one listed in AtomLinter#138. Fix things by loading the global Atom first and replacing keys set via a local config afterwards. Signed-off-by: Bert van Hall <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a local config in projects, the linter assumes every key is
defined and has a value. Especially if "execPath" is not set in the
local config, linter-gcc trips and produces stack traces like the one
listed in #138. Fix things by loading the global Atom first and
replacing keys set via a local config afterwards.