Intersecting each feature in a compound site with spatial too expensi… #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temi
reviewed
Jul 8, 2024
| } | ||
| } | ||
| else { | ||
| Map filtered = filterOutObjectsInBoundary(result, geometryCollection.getGeometryN(i)) |
There was a problem hiding this comment.
Looks like geometryCollection and i are not defined here.
There was a problem hiding this comment.
Thanks @temi I've fixed this.
temi
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ve #929
This change is to implement a single call to spatial to get intersecting objects from the layers, then perform the 5% overlap refinement individually for each site. This is because the calls to spatial to intersect against all of the layers takes a few seconds and repeating this few seconds for each shape in a MERIT outputs report was making the save take minutes.