Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move all aws support code into server_aws_common module #2735

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

havetisyan
Copy link
Collaborator

Description

  • To avoid conflicts between server and client codes the client RDL generator was updated to generate ClientResourceError and ClientResourceException classes. Otherwise we would get com.yahoo.athenz.zms.ResourceException both in the client and the server jar.
  • The exceptions thrown from server-common and server-aws-common are now checked exceptions so the servers can catch them and convert them to the zms.ResourceException and zts.ResourceException classes that the generate code is expecting them.

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Attach Screenshots (Optional)

@havetisyan havetisyan merged commit 1efc066 into 1.12.x-jetty12 Sep 20, 2024
3 checks passed
@havetisyan havetisyan deleted the common-aws branch September 20, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant