Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update interface to use both enterprise and cloud hostname resolvers #2615

Merged
merged 1 commit into from
May 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,11 @@ public interface StaticWorkloadDataRepository<T> {
/**
* Initializes the repository object
* @param privateKeyStore used to fetch necessary secrets to initialize the repository
* @param hostnameResolver used to resolve hostnames to ip addresses
* @param enterpriseHostnameResolver used to resolve hostnames to ip addresses for enterprise services
* @param cloudHostnameResolver used to resolve hostnames to ip addresses for cloud services
* @param msdStore used to fetch workload data from underlying storage
*/
void initialize(PrivateKeyStore privateKeyStore, HostnameResolver hostnameResolver, MsdStore msdStore);
void initialize(PrivateKeyStore privateKeyStore, HostnameResolver enterpriseHostnameResolver, HostnameResolver cloudHostnameResolver, MsdStore msdStore);

/**
* Returns static workload data from the corresponding repository
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,14 @@ public interface StaticWorkloadDataRepositoryFactory {
/**
* Creates the Repository objects
* @param privateKeyStore used to fetch necessary secrets to initialize the repository
* @param hostnameResolver used to resolve hostnames to ip addresses
* @param enterpriseHostnameResolver used to resolve hostnames to ip addresses for enterprise services
* @param cloudHostnameResolver used to resolve hostnames to ip addresses for cloud services
* @param msdStore used to fetch workload data from underlying storage
* @param type type of static workload to get appropriate repository from the factory implementation
* @return static workload data repository object
*/
<T> StaticWorkloadDataRepository<T> create(final PrivateKeyStore privateKeyStore, final HostnameResolver hostnameResolver, final MsdStore msdStore,
<T> StaticWorkloadDataRepository<T> create(final PrivateKeyStore privateKeyStore, final HostnameResolver enterpriseHostnameResolver,
final HostnameResolver cloudHostnameResolver,
final MsdStore msdStore,
final StaticWorkloadType type);
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public void testNoOpValidator() {

StaticWorkloadDataRepository<String> repository = new StaticWorkloadDataRepository<>() {
@Override
public void initialize(PrivateKeyStore privateKeyStore, HostnameResolver hostnameResolver, MsdStore msdStore) {
public void initialize(PrivateKeyStore privateKeyStore, HostnameResolver enterpriseHostnameResolver, HostnameResolver cloudHostnameResolver, MsdStore msdStore) {

}

Expand Down
Loading