Athenz Identity Provider for Harness (#2773)

* Athenz Identity Provider for Harness --------- Signed-off-by: Henry Avetisyan <[email protected]>
AthenZ · Oct 23, 2024 · e0b7faf · e0b7faf
1 parent 349dea9
commit e0b7faf
Show file tree

Hide file tree

Showing 18 changed files with 2,125 additions and 22 deletions.
diff --git a/libs/java/instance_provider/pom.xml b/libs/java/instance_provider/pom.xml
@@ -30,7 +30,7 @@
   <packaging>jar</packaging>
 
   <properties>
-    <code.coverage.min>0.9983</code.coverage.min>
+    <code.coverage.min>1.00</code.coverage.min>
   </properties>
 
   <dependencyManagement>

diff --git a/...e_provider/src/main/java/com/yahoo/athenz/instance/provider/impl/InstanceGCPProvider.java b/...e_provider/src/main/java/com/yahoo/athenz/instance/provider/impl/InstanceGCPProvider.java
@@ -52,7 +52,6 @@ public class InstanceGCPProvider implements InstanceProvider {
 
     DynamicConfigLong bootTimeOffsetSeconds; // boot time offset in seconds
     long certValidityTime;                   // cert validity for STS creds only case
-    boolean supportRefresh = false;
     String gcpRegion;
     Set<String> dnsSuffixes = null;
     List<String> gkeDnsSuffixes = null;
@@ -134,12 +133,8 @@ public void setExternalCredentialsProvider(ExternalCredentialsProvider externalC
     }
 
     public ProviderResourceException error(String message) {
-        return error(ProviderResourceException.FORBIDDEN, message);
-    }
-
-    public ProviderResourceException error(int errorCode, String message) {
         LOGGER.error(message);
-        return new ProviderResourceException(errorCode, message);
+        return new ProviderResourceException(ProviderResourceException.FORBIDDEN, message);
     }
 
     protected Set<String> getDnsSuffixes() {
@@ -298,14 +293,13 @@ public InstanceConfirmation confirmInstance(InstanceConfirmation confirmation) t
 
     @Override
     public InstanceConfirmation refreshInstance(InstanceConfirmation confirmation) throws ProviderResourceException {
+
         // if we don't have an attestation data then we're going to
-        // return not found exception unless the provider is required
-        // to support refresh and in that case we'll return forbidden
+        // return not forbidden exception
 
         final String attestationDataStr = confirmation.getAttestationData();
         if (StringUtil.isEmpty(attestationDataStr)) {
-            int errorCode = supportRefresh ? ProviderResourceException.FORBIDDEN : ProviderResourceException.NOT_FOUND;
-            throw error(errorCode, "No attestation data provided during refresh");
+            throw error("No attestation data provided during refresh");
         }
 
         GCPAttestationData attestationData = JSON.fromString(attestationDataStr, GCPAttestationData.class);