Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PEN and XLM tokens to Astar portal #1348

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

b-yap
Copy link

@b-yap b-yap commented Jul 2, 2024

@b-yap b-yap marked this pull request as ready for review July 2, 2024 12:54
@b-yap b-yap marked this pull request as draft July 2, 2024 12:54
@b-yap b-yap marked this pull request as ready for review July 2, 2024 13:11
@gtg7784 gtg7784 self-requested a review July 16, 2024 08:49
@bobo-k2 bobo-k2 self-requested a review July 16, 2024 09:09
@bobo-k2
Copy link
Contributor

bobo-k2 commented Jul 16, 2024

Thank you for the PR. Please send some test tokens to XLoLJBQoMPHMLXYhdFobSpH5GujRoUH8d1sUtaEtoBG7zaS

@bobo-k2 bobo-k2 requested a review from Kahonnohak July 16, 2024 09:22
@gtg7784
Copy link
Member

gtg7784 commented Jul 16, 2024

Hi @b-yap ! Thank you for contribute on our portal, can you send me PEN and XLM for testing it?

This is my Astar wallet address WGeDwTxHVMnbzNS7xkKsxfrabvimPkF96eBa7uYYbTDzNiG

Thank you :)

@b-yap
Copy link
Author

b-yap commented Jul 17, 2024

@bobo-k2 @gtg7784 Should I send test tokens to both accounts:
XLoLJBQoMPHMLXYhdFobSpH5GujRoUH8d1sUtaEtoBG7zaS
WGeDwTxHVMnbzNS7xkKsxfrabvimPkF96eBa7uYYbTDzNiG
?

Or any of these 2?

@gtg7784
Copy link
Member

gtg7784 commented Jul 17, 2024

@bobo-k2 @gtg7784 Should I send test tokens to both accounts: XLoLJBQoMPHMLXYhdFobSpH5GujRoUH8d1sUtaEtoBG7zaS WGeDwTxHVMnbzNS7xkKsxfrabvimPkF96eBa7uYYbTDzNiG ?

Or any of these 2?

Please send it to both, We want to test it on each environment.

Thank you :)

@bobo-k2
Copy link
Contributor

bobo-k2 commented Jul 17, 2024

After selecting Pendulum network
image
XCM component dissapears. This doesn't happen for other networks. I don't see any error in console
image

@b-yap
Copy link
Author

b-yap commented Jul 18, 2024

@bobo-k2 I have redeployed with a new vercel URL using the updated change: https://astar-apps-jnrb64nyx-bs-projects-fe8df2be.vercel.app/. https://astar-apps-b-yap-bs-projects-fe8df2be.vercel.app/
The problem was the token name. I set it as PEN, but it's actually defined as xcPEN in Astar.

@bobo-k2
Copy link
Contributor

bobo-k2 commented Jul 18, 2024

Hi @b-yap the new Vercel URL is asking me to authenticate, can you fix that?
image

@b-yap
Copy link
Author

b-yap commented Jul 18, 2024

@bobo-k2
Copy link
Contributor

bobo-k2 commented Jul 19, 2024

When I started testing I had 3 xcPEN on Pendulum. After that I made two transactions from Astar
to Pendulum and UI is still showing 3 xcPEN
https://astar.subscan.io/extrinsic/0x7c1352ba3daba47a01ff1c7831c7880fd73cc56c8b6e6cce469ae85d61cc088d
https://astar.subscan.io/extrinsic/0xba4004fccbf2e0c064f0f9950e287de7f9fe90a177bdbd01062a1537039b6896
image

I transfered 1 XLM.s from Astar to Pendulum and UI still showing 0 XML.s on Pendulum
https://astar.subscan.io/extrinsic/0xff7e7c92686805d76377c7b78919951db82e186f561a567f77a86226911fd0b2
image
After reloading the portal shows 0.042 XML.s?!
image

@b-yap b-yap marked this pull request as draft July 24, 2024 08:55
@b-yap
Copy link
Author

b-yap commented Jul 24, 2024

Moving this to draft, for now.

We identified that the minimum transfer amounts we use so far are not large enough to cover the XCM transfer fees charged on Pendulum. We are currently discussing which values we should use and will update the PR accordingly.

@b-yap
Copy link
Author

b-yap commented Jul 25, 2024

XLM transfer:
Beginning amounts:
Screenshot 2024-07-25 at 4 51 09 PM

Result after transferring 1.01 XLM Pendulum -> Astar
Screenshot 2024-07-25 at 4 56 38 PM

Result after transferring 1.1 XLM Astar -> Pendulum
Screenshot 2024-07-25 at 5 00 38 PM

Result after transferring 1 XLM Pendulum -> Astar
Screenshot 2024-07-25 at 5 07 32 PM

@b-yap
Copy link
Author

b-yap commented Jul 25, 2024

PEN transfer:
Beginning amounts:
Screenshot 2024-07-25 at 11 37 00 PM

Result after transferring 2.01 PEN Pendulum -> Astar:
Screenshot 2024-07-25 at 11 38 36 PM

Result after transferring 2 PEN Pendulum -> Astar:
Screenshot 2024-07-25 at 11 41 22 PM

Result after transferring 2.5 PEN Astar -> Pendulum:
Screenshot 2024-07-25 at 11 43 06 PM

@b-yap b-yap marked this pull request as ready for review July 30, 2024 06:19
@b-yap
Copy link
Author

b-yap commented Jul 30, 2024

@bobo-k2 We have increased the minimum transferred amounts, thus gave you more XLMs and PENs to play with.
Vercel link: https://astar-apps-bs-projects-fe8df2be.vercel.app/

@bobo-k2
Copy link
Contributor

bobo-k2 commented Aug 9, 2024

Hi @b-yap and thank you for the update. Another problem arise in the meantime. I believe this happens because outdated polkadot.js version. Please merge main into your branch. We uplifted polkadot.js to the latest version recently.
image

@b-yap
Copy link
Author

b-yap commented Aug 12, 2024

Hello @bobo-k2 , updated: 9b5c335

Also updated in vercel: https://astar-apps-b-yap-bs-projects-fe8df2be.vercel.app/

@bobo-k2
Copy link
Contributor

bobo-k2 commented Aug 13, 2024

Hi @b-yap now I am having different error. Did you try Vercel deployment?
image

@b-yap
Copy link
Author

b-yap commented Aug 13, 2024

Hi @bobo-k2
Not sure what happened in Vercel, my apologies.

I redeployed again (doing yarn -> yarn build all over again):
Screenshot 2024-08-13 at 8 49 07 PM
https://astar.subscan.io/extrinsic/0x7a9ec7bb4776cb5baf986931d71e1a52ec626cd22731c2fda7215c91e0cd5649

Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@impelcrypto
Copy link
Member

Hi @b-yap
Could you send some tokens to test? Thanks!
5H6DC1YjyD531FiGxPCpWY3WNJrp5kQ35xHm6wibKuFvWzKW

@prayagd
Copy link

prayagd commented Aug 26, 2024

@annatekl can you please get @impelcrypto the required tokens to test?

@annatekl
Copy link

5H6DC1YjyD531FiGxPCpWY3WNJrp5kQ35xHm6wibKuFvWzKW

sent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants