Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client.transcripts.list_by_url & update README.md #14

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Add client.transcripts.list_by_url & update README.md #14

merged 6 commits into from
Feb 28, 2024

Conversation

Swimburger
Copy link
Collaborator

Add client.transcripts.list_by_url & update README.md

@Swimburger
Copy link
Collaborator Author

@armandobelardo Does list_by_url look good? Is this naming good by Ruby conventions?

@armandobelardo
Copy link
Collaborator

Thank you for adding this!
You'll also want to add an import to the root client: https://github.com/AssemblyAI/assemblyai-ruby-sdk/blob/main/lib/assemblyai.rb (see line 8, apologies I couldn't link to the line on mobile)

After both changes I can test this out locally

@Swimburger
Copy link
Collaborator Author

Does it work now?

@Swimburger Swimburger merged commit 4851439 into main Feb 28, 2024
1 check passed
@Swimburger Swimburger deleted the niels/readme+list branch February 28, 2024 22:03
@Swimburger
Copy link
Collaborator Author

Thanks for the updates and test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armandobelardo armandobelardo Awaiting requested review from armandobelardo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Swimburger @armandobelardo