Merge pull request #33 from AssemblyAI/E07417BDFEA3614F5967B1520F8B2F61

Release 4.2.2

CHANGELOG.md

@@ -1,11 +1,19 @@
 # Changelog
 
+## [4.2.2] - 2024-01-29
+
+### Changed
+
+- Windows paths passed to `client.transcripts.transcribe` and `client.transcripts.submit` will work as expected.
+
 ## [4.2.1] - 2024-01-23
 
 ### Added
+
 - Add `answer_format` to `LemurActionItemsParams` type
 
 ### Changed
+
 - Rename `RealtimeService` to `RealtimeTranscriber`, `RealtimeServiceFactory` to `RealtimeTranscriberFactory`, `RealtimeTranscriberFactory.createService()` to `RealtimeTranscriberFactory.transcriber()`. Deprecated aliases are provided for all old types and functions for backwards compatibility.
 - Restrict the type for `redact_pii_audio_quality` from `string` to `RedactPiiAudioQuality` an enum string.
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "assemblyai",
-  "version": "4.2.1",
+  "version": "4.2.2",
   "description": "The AssemblyAI JavaScript SDK provides an easy-to-use interface for interacting with the AssemblyAI API, which supports async and real-time transcription, as well as the latest LeMUR models.",
   "engines": {
     "node": ">=18"

src/services/transcripts/index.ts

@@ -21,6 +21,7 @@ import {
   SubmitParams,
 } from "../..";
 import { FileService } from "../files";
+import { getPath } from "../../utils/path";
 
 export class TranscriptService
   extends BaseService
@@ -249,14 +250,3 @@ export class TranscriptService
     );
   }
 }
-
-function getPath(path: string) {
-  let url: URL;
-  try {
-    url = new URL(path);
-    if (url.protocol === "file:") return url.pathname;
-    else return null;
-  } catch {
-    return path;
-  }
-}

src/utils/path.ts

@@ -0,0 +1,7 @@
+export function getPath(path: string) {
+  if (path.startsWith("http")) return null;
+  if (path.startsWith("https")) return null;
+  if (path.startsWith("file://")) return path.substring(7);
+  if (path.startsWith("file:")) return path.substring(5);
+  return path;
+}

tests/utils.test.ts

@@ -1,5 +1,6 @@
 import fetchMock from "jest-fetch-mock";
 import { AssemblyAI } from "../src";
+import { getPath } from "../src/utils/path";
 
 fetchMock.enableMocks();
 
@@ -24,4 +25,31 @@ describe("utils", () => {
     fetchMock.mockResponseOnce(JSON.stringify(error), { status: 500 });
     await expect(() => assembly.transcripts.get("123")).rejects.toThrow(error);
   });
+
+  it("should return correct path", () => {
+    const dict = [
+      ["path/to/file", "path/to/file"],
+      ["/path/to/file", "/path/to/file"],
+      ["./path/to/file", "./path/to/file"],
+      ["C:/path/to/file", "C:/path/to/file"],
+      ["D:/path/to/file", "D:/path/to/file"],
+      ["C:\\path\\to\\file", "C:\\path\\to\\file"],
+      ["D:\\path\\to\\file", "D:\\path\\to\\file"],
+      ["http://example.com", null],
+      ["https://example.com", null],
+      ["file://path/to/file", "path/to/file"],
+      ["file://C:/path/to/file", "C:/path/to/file"],
+      ["file://D:/path/to/file", "D:/path/to/file"],
+      ["file:path/to/file", "path/to/file"],
+      ["file:C:/path/to/file", "C:/path/to/file"],
+      ["file:D:/path/to/file", "D:/path/to/file"],
+      ["file:C:\\path\\to\\file", "C:\\path\\to\\file"],
+      ["file:D:\\path\\to\\file", "D:\\path\\to\\file"],
+      ["file://C:\\path\\to\\file", "C:\\path\\to\\file"],
+      ["file://D:\\path\\to\\file", "D:\\path\\to\\file"],
+    ];
+    for (const [input, output] of dict) {
+      expect(getPath(input as string)).toEqual(output);
+    }
+  });
 });