[feat] I2c refactor to enable system level resource management #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ait. - Introduce init_with_system_control function. - Make init function fallible.
1 - Introduce `init_peripheral_only()` that handles only: - I2C controller register setup (`i2c.i2cc00()`) - Interrupt configuration (`i2c.i2cm10()`, `i2c.i2cm14()`) - Slave mode setup (if enabled) - Timing configuration (peripheral-level only) 2. Introduce init_i2c_global_system<S: ResetControl>(system_control: &mut S)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I2C Initialization Improvement
The original
init()function had architectural limitations that prevented integration with system control task architectures:I need help debugging and testing - this code is meant to serve more as a sample since I am not an expert in the ASPEED hardware.