hmac: introduce hmac driver #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has more changes than what is described in the summary. Let's break this into smaller units. |
Add rsa driver based on the implementation in aspeed zephyr sdk.
The patch also add functional test and rsa test data generator.
How to verify driver:
1. You may use the existing test vectors in tests/functional/rsa_test_vec.rs, or
2. Generate fresh vectors by running:
python3 scripts/rsa_test_vec_gen.py > src/tests/functional/rsa_test_vec.rs
3. Build and run the image
Signed-off-by: Steven Lee <[email protected]>
Add hmac driver based on the implementation in aspeed zephyr sdk. Currently, accumulative (multi-part) mode is not supported, aligning with the limitations of the original Zephyr driver. Signed-off-by: Steven Lee <[email protected]>
Signed-off-by: Steven Lee <[email protected]>
Signed-off-by: Steven Lee <[email protected]>
|
We have some code duplication here. Given that both digest and hmac operations are provided by the underlying HACE we should factor out the Controller type into its own module. I have made the changes here, if you want to use them as a reference. |
Refactoring driver to remove duplicated code. Merge from: rusty1968@67a3994 Signed-off-by: Steven Lee <[email protected]>
Signed-off-by: Steven Lee <[email protected]>
|
@rusty1968 The duplicated code has been removed. It's ready for your review, thanks in advance! |
- Addressed clippy lints for needless lifetimes, etc. - Ran cargo fmt for formatting consistency Signed-off-by: Steven Lee <[email protected]>
Removed needless lifetimes. Signed-off-by: Steven Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hmac driver based on the implementation in aspeed zephyr sdk.
Currently, accumulative (multi-part) mode is not supported, aligning
with the limitations of the original Zephyr driver.