Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance optimization #14

Merged

Conversation

zidaye
Copy link
Contributor

@zidaye zidaye commented Dec 12, 2023

close #10

# run
cargo bench --bench my_benchmark -- --verbose

8 files, each with a size of 10 MB, uploaded in approximately 3.3 seconds. The speed is 24 MB/s.

image

In fact, by modifying the code to increase concurrency, it is possible to achieve an upload speed of 30-40 MB/s.

like this:

let (handle_sender, session_receiver) = channel(64);

@AspectUnk AspectUnk self-requested a review May 6, 2024 22:32
@AspectUnk AspectUnk changed the base branch from master to features/concurrency May 6, 2024 22:36
@AspectUnk AspectUnk merged commit 9f7d2ed into AspectUnk:features/concurrency May 6, 2024
@AspectUnk
Copy link
Owner

Thanks for taking the time to do this. This implementation has several synchronization problems, including handles, and the request_id itself can be atomic, but I will fix all this myself in another branch.

@UVUUUVUU
Copy link

UVUUUVUU commented May 9, 2024

Thanks for taking the time to do this. This implementation has several synchronization problems, including handles, and the request_id itself can be atomic, but I will fix all this myself in another branch.

This has been very helpful in my work and I am very much looking forward to this part of the feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File transfer example
3 participants