Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ApplicationController::onOpenURL support #14

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mrexodia
Copy link
Contributor

Based on #13

CMakeLists.txt:

[...]

ios_configure_app_info(TARGET Authenticator
    LAUNCHSCREEN "LaunchScreen"
    TARGETED_DEVICES IPHONE IPAD
    IPHONE_ORIENTATIONS ALL
    IPAD_ORIENTATIONS ALL
    URI_ROLE Editor
    URI_HANDLERS otpauth totp)

[...]

For now only iOS support, but there should be a similar feature on Android. No documentation was updated and only manual testing was performed (By scanning a QR code with an otpauth:// url and allowing it to open my app, see: http://security-totp.appspot.com).

Please let me know if this is a desired feature, I can do more work if needed but couldn't really find any contributor guidelines.

@gitoby
Copy link
Contributor

gitoby commented Jul 23, 2019

Thanks for contributing!

We are currently in the process of ramping up our contribution guidelines and, most importantly, contribution license agreement. I will get back to you tomorrow.

@gitoby
Copy link
Contributor

gitoby commented Jul 24, 2019

We've committed a Contribution License Agreement for Boden at https://github.com/AshampooSystems/boden/blob/master/CLA.md (CLA). Your consent is required for us to accept your contributions. Please review the agreement and let me know whether you agree to it. There is no need to sign the agreement for now. It is effective upon your submission — and in this special case — upon your consent here since the CLA has not been online when you submitted this PR.

@gitoby gitoby self-requested a review July 24, 2019 14:27
@mrexodia
Copy link
Contributor Author

Yeah the CLA looks fine for me and I agree to it!

@gitoby
Copy link
Contributor

gitoby commented Jul 24, 2019

Great, thank you! We will review your PRs in the next days and get back to you if needed.

@gitoby
Copy link
Contributor

gitoby commented Jul 25, 2019

Thanks a lot for adding this! Looks great! It's definitely a desired feature.

We don't have contribution guidelines (wip), so here are the most important points that I think you need to know:

  • We currently use an internal Jenkins build agent for building public PRs, so unfortunately you cannot see the build output directly. We will change that in the future, but for now we'd just message you if something fails there.
  • We currently run clangformat manually on all PRs and this is a requirement for them to pass CI. You can run clangformat using Xcode by selecting the "FormatSources" target and hitting run.
  • We have an internal code style guide, but for now there are no special requirements. We may refine or change details if they look inconsistent with the rest of the framework.
  • Every feature that gets pulled must work on iOS and Android. macOS support is optional, but would also be nice.
  • If you want to write documentation for your PR that's great, but it's not a requirement. We're happy to add that if you have more important things to do. I might come back to you with questions in that case though.
  • Automated tests are not a requirement currently, but are definitely desirable. We will do manual testing within sprints and regression tests before releases.

Please let us know whether you are willing to put more work into this. If not, we'll be keeping this open and prioritize the feature in the next sprint planning meeting.

Copy link
Contributor

@gitoby gitoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in the PR thread

@mrexodia
Copy link
Contributor Author

It's fine for me to put additional work into this feature. I discovered the .clang-format file yesterday and I will rebase and adjust the commits to format everything correctly.

I closed #13 because this PR includes those changes. And I made the free space to install Android Studio so I will at least get things to compile there and I will try to implement it this weekend when I'm back home.

@gitoby
Copy link
Contributor

gitoby commented Jul 25, 2019

Great! Let me know if we can help. Looking forward to your PR!

@mrexodia
Copy link
Contributor Author

mrexodia commented Aug 7, 2019

For iOS this is working, unfortunately I'm having a really hard time working with Android Studio and my Android experience is very limited, so I won't be able to implement it there.

@gitoby
Copy link
Contributor

gitoby commented Aug 12, 2019

OK, no problem. We will have a look. Thanks for your work on this!

@cdelabrouhe
Copy link

Is there any news about Boden ? Nothing for 8 months, is it still in dev ?

@lexuanquynh
Copy link

Is there any news about Boden ? Nothing for 2 years, is it still in dev ?

@frak0d
Copy link

frak0d commented Jul 23, 2022

Is there any active fork of boden ?
I feel like this shouldn't die.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants