Conversation
Co-authored-by: rebelinux <1002783+rebelinux@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Migrate Forest section to add En-US multilingual support
Migrate Forest section to multilingual support via MicrosoftAD.psd1
Mar 4, 2026
|
PSScriptAnalyzer results: Errors: [0], Warnings: [31], Information: [0]
|
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the Forest report section to the module’s localization system by moving previously hardcoded English strings into MicrosoftAD.psd1 and updating report logic to reference translated property names safely.
Changes:
- Added
GetAbrForestSectiontranslation keys and expandedGetAbrADForestkeys inLanguage/en-US/MicrosoftAD.psd1. - Updated
Get-AbrForestSection.ps1andGet-AbrADForest.ps1to use$reportTranslate.*strings (including fixing dynamic property references used byWhere-Object/Set-Style). - Added
Language/es-ES/MicrosoftAD.psd1to satisfy existing module/test expectations for thees-ESlocale.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Src/Private/Get-AbrForestSection.ps1 | Replaces hardcoded Forest section strings with localized keys. |
| Src/Private/Get-AbrADForest.ps1 | Localizes headings/text and fixes style/filters to use translated property names. |
| Language/en-US/MicrosoftAD.psd1 | Adds/extends localization keys for Forest/ADForest sections. |
| Language/es-ES/MicrosoftAD.psd1 | Adds required es-ES locale file (placeholder content). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
PSScriptAnalyzer results: Errors: [0], Warnings: [31], Information: [0]
|
…ltipleRootCABP Co-authored-by: rebelinux <1002783+rebelinux@users.noreply.github.com>
|
PSScriptAnalyzer results: Errors: [0], Warnings: [31], Information: [0]
|
Collaborator
|
@copilot now migrate the rest of the Forest section:
|
…AbrADSite to localization system Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: rebelinux <1002783+rebelinux@users.noreply.github.com>
Contributor
Author
Done in commit
All keys added to |
|
PSScriptAnalyzer results: Errors: [0], Warnings: [31], Information: [0]
|
rebelinux
requested changes
Mar 4, 2026
…scripts Co-authored-by: rebelinux <1002783+rebelinux@users.noreply.github.com>
|
PSScriptAnalyzer results: Errors: [0], Warnings: [33], Information: [0]
|
Collaborator
|
@copilot code review[agent] evaluate if all of the text were migrated to multi language support |
…es in Domain section scripts Co-authored-by: rebelinux <1002783+rebelinux@users.noreply.github.com>
Contributor
Author
Fixed in commit
16 new localization keys added to |
Collaborator
|
@copilot now migrate all remaining cmdlet to support multi language |
Contributor
Author
The following 13 scripts still need to be migrated to multilingual support (they were not covered in the previous sessions):
I ran out of time in this session before completing them. They will be addressed in the next session. |
… DCRoleFeature, DCDiag, InfraService) to localization Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…zation - Migrate Get-AbrADDFSHealth.ps1 to multilingual support - Migrate Get-AbrADKerberosAudit.ps1 to multilingual support - Migrate Get-AbrADSiteReplication.ps1 to multilingual support - Migrate Get-AbrADOU.ps1 to multilingual support - Add GetAbrADDFSHealth, GetAbrADKerberosAudit, GetAbrADSiteReplication, GetAbrADOU key groups to en-US and es-ES PSD1 files - Fix pre-existing Sort-Object bug in Get-AbrADSiteReplication.ps1 (was sorting by 'Source DSA' which never existed as a column) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add GetAbrADSecurityAssessment key group (46 keys) to en-US and es-ES PSD1 - Add GetAbrADGPO key group (87 keys) to en-US and es-ES PSD1 - Migrate Get-AbrADSecurityAssessment.ps1 to use $reportTranslate keys for all user-visible strings including section titles, paragraphs, column names, health check texts, and localized Yes/No/Unknown values - Migrate Get-AbrADGPO.ps1 to use $reportTranslate keys across all nine sections: main summary, detail view, WMI Filters, Central Store, Logon/Logoff Script, Startup/Shutdown Script, Unlinked GPO, Empty GPOs, Enforced GPO, and Orphaned GPO Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…roller PS1 pending) Co-authored-by: rebelinux <1002783+rebelinux@users.noreply.github.com>
Copilot
AI
changed the title
Migrate Forest, DNS, PKI, and Domain sections to multilingual support via MicrosoftAD.psd1
Migrate all remaining cmdlets to multilingual support via MicrosoftAD.psd1
Mar 5, 2026
Co-authored-by: rebelinux <1002783+rebelinux@users.noreply.github.com>
Copilot
AI
changed the title
Migrate all remaining cmdlets to multilingual support via MicrosoftAD.psd1
Migrate all remaining hardcoded strings in Private cmdlets to multilingual localization
Mar 5, 2026
|
PSScriptAnalyzer results: Errors: [0], Warnings: [45], Information: [0]
|
Co-authored-by: rebelinux <1002783+rebelinux@users.noreply.github.com>
Copilot
AI
changed the title
Migrate all remaining hardcoded strings in Private cmdlets to multilingual localization
feat: complete localization of all remaining hardcoded strings in Src/Private and Src/Public
Mar 6, 2026
|
PSScriptAnalyzer results: Errors: [0], Warnings: [45], Information: [0]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several user-visible strings across four files were still hardcoded instead of going through the
$reportTranslatelocalization system used everywhere else in the codebase.Hardcoded strings replaced
Invoke-AsBuiltReport.Microsoft.AD.ps1—'DISCLAIMER'section titleGet-AbrADForest.ps1—'Certificate Authority Diagram'(section heading +Image -Text)Get-AbrADDomainController.ps1—'Domain Controller Object - Chart'(Image -Text)Get-AbrADSecurityAssessment.ps1— 6 strings: user account diagram alt-text, privileged-users email note, delegation footnote, reference label, reference URL, and service-accounts AdminCount notePSD1 keys added
9 new keys added to both
Language/en-US/MicrosoftAD.psd1andLanguage/es-ES/MicrosoftAD.psd1(es-ES entries are properly translated):InvokeAsBuiltReportMicrosoftADDisclaimerSectionGetAbrADForestCADiagramGetAbrADDomainControllerDCObjectChartGetAbrADSecurityAssessmentUserAccountDiagram,PrivilegedUsersEmailNote,PrivilegedUsersDelegationNote,PrivilegedUsersReference,PrivilegedUsersReferenceURL,ServiceAccountsAdminCountNoteExample
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www.powershellgallery.com/usr/bin/pwsh pwsh -Command Install-Module Pester -Force -SkipPublisherCheck -ErrorAction SilentlyContinue Import-Module Pester -Force Invoke-Pester -Path 'Tests/' -Output Detailed 2>&1(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.